----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26510/#review56070 -----------------------------------------------------------
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java <https://reviews.apache.org/r/26510/#comment96423> The NPE seems to be from, line 782: commandParamsStageCache.put(stagePk, commandParams) Seems like we have command params as null so guava cache complains about it. Maybe, "StageUtils.getGson().fromJson(s.getCommandParamsStage(), type)" returns null for empty string, note: we are passing empty string for comandParamsStage. Not sure how this would be resolved after some time? A null check in ActionScheduler might not be a bad idea, your call. - Sid Wagle On Oct. 9, 2014, 10:05 p.m., jun aoki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26510/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2014, 10:05 p.m.) > > > Review request for Ambari and Yusaku Sako. > > > Bugs: AMBARI-7622 > https://issues.apache.org/jira/browse/AMBARI-7622 > > > Repository: ambari > > > Description > ------- > > Tweaked the waiting condition upon ActionScheduler > > > Diffs > ----- > > > ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java > a20f252 > > Diff: https://reviews.apache.org/r/26510/diff/ > > > Testing > ------- > > > Thanks, > > jun aoki > >
