----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26576/#review56233 -----------------------------------------------------------
Very good to see this. One thing is that I don't think we should be introducing a new service to the 2.1 stack; it should just be for 2.2 and onward. - Yusaku Sako On Oct. 10, 2014, 9:46 p.m., Jaimin Jetly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26576/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2014, 9:46 p.m.) > > > Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako. > > > Bugs: AMBARI-7685 > https://issues.apache.org/jira/browse/AMBARI-7685 > > > Repository: ambari > > > Description > ------- > > This adds a new stack definition for knox service in HDP-2.1 stack (nagios > alerts are integrated for knox gateway daemon). Includes needed UI changes > along with unit test. > > Remaining tasks for knox integration after this patch is committed: > # Support for knox in kerberized ambari cluster. > # Support for knox in HDP-2.2 stack. > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/nagios_alerts.php > 0e1e501 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/params.py > ec6c885 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-servicegroups.cfg.j2 > aee9b15 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-services.cfg.j2 > f69238e > > ambari-server/src/main/resources/stacks/HDP/2.1/services/KNOX/configuration/ambari-topology.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.1/services/KNOX/configuration/gateway-log4j.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.1/services/KNOX/configuration/gateway-site.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.1/services/KNOX/configuration/knox-env.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.1/services/KNOX/configuration/ldap-log4j.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.1/services/KNOX/configuration/users-ldif.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.1/services/KNOX/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.1/services/KNOX/package/scripts/knox.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.1/services/KNOX/package/scripts/knox_gateway.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.1/services/KNOX/package/scripts/ldap.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.1/services/KNOX/package/scripts/params.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.1/services/KNOX/package/scripts/service_check.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.1/services/KNOX/package/scripts/status_params.py > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/metainfo.xml > PRE-CREATION > ambari-server/src/test/python/stacks/2.1/KNOX/test_knox_gateway.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.1/configs/default.json cdb70f4 > ambari-web/app/controllers/main/service/item.js 8990a39 > ambari-web/app/data/HDP2/site_properties.js 19299bc > ambari-web/app/messages.js 6d8e0fc > ambari-web/app/models/service_config.js 595f604 > ambari-web/app/models/stack_service.js 0d4d30e > ambari-web/app/utils/ajax/ajax.js cc3e325 > ambari-web/app/utils/config.js b3d363a > ambari-web/app/views/main/service/item.js 929c212 > ambari-web/test/controllers/main/service/item_test.js 4f94eda > > Diff: https://reviews.apache.org/r/26576/diff/ > > > Testing > ------- > > tested e2e > > > Thanks, > > Jaimin Jetly > >
