-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26676/
-----------------------------------------------------------

(Updated Oct. 14, 2014, 1:48 p.m.)


Review request for Ambari, Nate Cole and Srimanth Gunturi.


Changes
-------

try again...


Bugs: AMBARI-7768
    https://issues.apache.org/jira/browse/AMBARI-7768


Repository: ambari


Description
-------

Masked view param is not encoded when the view-instance gets created. Due to 
this, the decoded value is being decoded again, resulting in garbled values.


Diffs (updated)
-----

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java
 9a48b41 
  
ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java 
0254113 
  ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
b1cec01 
  
ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java 
e6a20b3 

Diff: https://reviews.apache.org/r/26676/diff/


Testing
-------

Manual testing.

Unit tests updated.  All tests pass.

...

Results :

Tests run: 2168, Failures: 0, Errors: 0, Skipped: 16

...

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 31:57.991s
[INFO] Finished at: Tue Oct 14 07:09:56 EDT 2014
[INFO] Final Memory: 31M/225M
[INFO] ------------------------------------------------------------------------


Thanks,

Tom Beerbower

Reply via email to