----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26757/#review56745 -----------------------------------------------------------
Ship it! Ship It! - Nate Cole On Oct. 15, 2014, 12:49 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26757/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2014, 12:49 p.m.) > > > Review request for Ambari, Dmytro Sen and Nate Cole. > > > Bugs: AMBARI-7791 > https://issues.apache.org/jira/browse/AMBARI-7791 > > > Repository: ambari > > > Description > ------- > > At jira https://issues.apache.org/jira/browse/AMBARI-6358 we had a > requirement to have only one 'HBase Master CPU utilization' check even in HA > mode. So this check is bound to Nagios host (to be executed only once even if > hbase master hostgroup has more than one host, like it is done for "* Percent > Count" alerts). As a result, Hbase Master alert origin data does not match > any entry at file /var/nagios/ignore.dat . That's why the alert is not > suppressed. > > Fixed many similar issues with other checks. Had to add a new check wrapper > for that. > > > Diffs > ----- > > ambari-server/src/main/python/ambari-server.py 4988708 > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/check_wrapper.sh > 8c36a79 > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/files/mm_wrapper.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/scripts/nagios_server_config.py > 4d452c6 > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-commands.cfg.j2 > a81762f > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/hadoop-services.cfg.j2 > 6ce5d10 > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/NAGIOS/package/templates/nagios.cfg.j2 > aa37a01 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_checkpoint_time.py > 6848e17 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/check_wrapper.sh > d350e4f > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/mm_wrapper.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/nagios_server_config.py > 4efce9b > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-commands.cfg.j2 > 9a6f7a4 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-services.cfg.j2 > 1ed55d1 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/nagios.cfg.j2 > d51471b > ambari-server/src/test/python/stacks/1.3.2/NAGIOS/test_mm_wrapper.py > PRE-CREATION > ambari-server/src/test/python/stacks/1.3.2/NAGIOS/test_nagios_server.py > 17f0dca > ambari-server/src/test/python/stacks/2.0.6/NAGIOS/test_mm_wrapper.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.0.6/NAGIOS/test_nagios_server.py > 58c04f3 > ambari-server/src/test/python/unitTests.py 773a698 > > Diff: https://reviews.apache.org/r/26757/diff/ > > > Testing > ------- > > ---------------------------------------------------------------------- > Ran 234 tests in 4.714s > > OK > ---------------------------------------------------------------------- > Total run:664 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Dmitro Lisnichenko > >
