> On Oct. 20, 2014, 5:25 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py, > > line 215 > > <https://reviews.apache.org/r/26934/diff/2/?file=725768#file725768line215> > > > > This will not work in future stacks. Why not do > > int("".join(stack_version.split(".")[:2])) >= 22 > > > > Or actually write a function to do this. > > I believe we already have a function to compare Ambari versions, so we > > can use the similar logic for HDP.
Conversion to int might not work in some cases - Dmitro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26934/#review57366 ----------------------------------------------------------- On Oct. 20, 2014, 3:32 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26934/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2014, 3:32 p.m.) > > > Review request for Ambari, Dmytro Sen and Vitalyi Brodetskyi. > > > Bugs: AMBARI-7863 > https://issues.apache.org/jira/browse/AMBARI-7863 > > > Repository: ambari > > > Description > ------- > > Pig on Tez will be in Champlain and we need Ambari support it > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py > 1308aa2 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/utils.py > 5e1221a > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/params.py > 785b89d > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/service_check.py > 7619bd6 > ambari-server/src/main/resources/stacks/HDP/2.2/services/PIG/metainfo.xml > bd0b5ce > > Diff: https://reviews.apache.org/r/26934/diff/ > > > Testing > ------- > > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main ....................................... SUCCESS [2.398s] > [INFO] Apache Ambari Project POM ......................... SUCCESS [0.173s] > [INFO] Ambari Web ........................................ SUCCESS [44.231s] > [INFO] Ambari Views ...................................... SUCCESS [2.718s] > [INFO] Ambari Admin View ................................. SUCCESS [59.651s] > [INFO] Ambari Server ..................................... SUCCESS [43.740s] > [INFO] Ambari Agent ...................................... SUCCESS [5.398s] > [INFO] Ambari Client ..................................... SUCCESS [0.002s] > [INFO] Ambari Python Client .............................. SUCCESS [1.114s] > [INFO] Ambari Groovy Client .............................. SUCCESS [3.191s] > [INFO] Ambari Shell ...................................... SUCCESS [0.003s] > [INFO] Ambari Python Shell ............................... SUCCESS [0.003s] > [INFO] Ambari Groovy Shell ............................... SUCCESS [3.005s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Dmitro Lisnichenko > >
