----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27103/#review58157 -----------------------------------------------------------
dev-support/docker/docker/bin/ambaribuild.py <https://reviews.apache.org/r/27103/#comment99080> We should follow PEP8 style guide. functions_like_this variables_also_like_this And 2-space indents (even though PEP8 suggests 4) dev-support/docker/docker/bin/ambaribuild.py <https://reviews.apache.org/r/27103/#comment99082> Is it necessary for these functions to return the return code? dev-support/docker/docker/bin/ambaribuild.py <https://reviews.apache.org/r/27103/#comment99083> Why not define these values as constants? dev-support/docker/docker/bin/ambaribuild.py <https://reviews.apache.org/r/27103/#comment99085> We should follow the convention of a separate file for unit tests. dev-support/docker/docker/bin/ambaribuild.py <https://reviews.apache.org/r/27103/#comment99087> All of these if-blocks should check the return codes of the processes before continuing. - Alejandro Fernandez On Oct. 23, 2014, 6:40 p.m., jun aoki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27103/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2014, 6:40 p.m.) > > > Review request for Ambari. > > > Bugs: AMBARI-7875 > https://issues.apache.org/jira/browse/AMBARI-7875 > > > Repository: ambari > > > Description > ------- > > Run Ambari build and test on Docker container. > This way, we have more flexibility for third party libraries and build > environment. > Currently JDK 1.6 and Python 2.6 should be supported but > https://builds.apache.org/view/A-D/view/Ambari/job/Ambari-trunk-Commit/ > runs on JDK1.7, which is a discrepancy. > > > Diffs > ----- > > dev-support/docker/README.md PRE-CREATION > dev-support/docker/docker/Dockerfile PRE-CREATION > dev-support/docker/docker/bin/ambaribuild.py PRE-CREATION > dev-support/docker/docker/blueprints/single-node-HDP-2.1-blueprint1.json > PRE-CREATION > dev-support/docker/docker/blueprints/single-node-hostmapping1.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/27103/diff/ > > > Testing > ------- > > https://builds.apache.org/view/A-D/view/Ambari/job/Ambari-trunk-Commit-docker > > > Thanks, > > jun aoki > >
