-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27133/
-----------------------------------------------------------

Review request for Ambari, Andriy Babiichuk and Oleg Nechiporenko.


Bugs: AMBARI-7945
    https://issues.apache.org/jira/browse/AMBARI-7945


Repository: ambari


Description
-------

1) Hive:hive.tez.container.size. The tooltip mentions that the value "Must be 
assigned the same value as mapreduce.map.child.java.opts". This is not correct, 
the values have no dependency on each other (tez container size is independent 
of Java Opts, especially mapreduce java opts). Recommendation: delete the 
sentence.
2) Hive:hive.tez.java.opts. The tooltip is also incorrect: "Must be assigned 
the same value as mapreduce.map.java.opts". Seems like a copy paste from the 
above. Recommendation: change the sentence to "The -Xmx parameter value is 
generally 80% of hive.tez.container.size"
3) Hive:hive.security.authorization.enabled: this could be a checkbox rather 
than a textbox
Note: For #3, for this to be a checkbox, decide whether this property should be 
set by default as false so the UI styling can be a checkbox. Currently, this is 
added as a custom prop (since it's not part of default) so it just follows 
generic input textbox layout.


Diffs
-----

  
ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml
 dc03534 
  ambari-web/app/data/HDP2/site_properties.js 44d97d9 

Diff: https://reviews.apache.org/r/27133/diff/


Testing
-------

Tested manually


Thanks,

Andrii Tkach

Reply via email to