-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27194/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley and Nate Cole.
Bugs: AMBARI-7964
https://issues.apache.org/jira/browse/AMBARI-7964
Repository: ambari
Description
-------
On view deploy: perform validation of view.xml in view package and if the
view.xml does not validate, provide a specific error to the log.
Validation can be an optional operation that can be enabled/disabled in the
ambari server (maybe just a prop in ambari.properties
view.validation.enabled=true/false)?
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
535e569
ambari-server/src/main/java/org/apache/ambari/server/view/ViewArchiveUtility.java
f5f2732
ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java
c4da8b4
ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
12b5333
ambari-server/src/test/java/org/apache/ambari/server/view/ViewArchiveUtilityTest.java
PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/view/ViewExtractorTest.java
1b71c37
ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java
7c0cade
ambari-server/src/test/resources/test_view.xml PRE-CREATION
Diff: https://reviews.apache.org/r/27194/diff/
Testing
-------
Manual testing. New unit tests added. All existing pass ...
Results :
Tests run: 2202, Failures: 0, Errors: 0, Skipped: 14
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 36:45.663s
[INFO] Finished at: Sat Oct 25 08:06:24 EDT 2014
[INFO] Final Memory: 41M/344M
[INFO] ------------------------------------------------------------------------
Thanks,
Tom Beerbower
