----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27229/#review58614 -----------------------------------------------------------
Ship it! Ship It! - Andrii Tkach On Окт. 27, 2014, 4:12 п.п., Aleksandr Kovalenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27229/ > ----------------------------------------------------------- > > (Updated Окт. 27, 2014, 4:12 п.п.) > > > Review request for Ambari and Andrii Tkach. > > > Bugs: AMBARI-7984 > https://issues.apache.org/jira/browse/AMBARI-7984 > > > Repository: ambari > > > Description > ------- > > Alerts UI needs to model Alert-Definitions and Alert-Instances as classes. > > Alert-Definition class is: > * id (number) > * name (string) > * label (string) > * serviceName (string) > * componentName (string) > * enabled (boolean) > * scope (string) > * interval (number) > * type (string) // "SCRIPT" | "METRIC" | "AGGREGATE" | "PERCENT" | "PORT" > > > Alert-Report-Definition class: > * type (string) - OK, Warning, Critical > * text (string) > * value (number) - may not exist > > Alert-Metrics-Source-Definition class: > * propertyList (string[]) > * value (string) > > > Port-Alert-Definition class extends Alert-Definition class: > * defaultPort (number) > * uri (string) > * reporting (Alert-Report-Definition[]) > > Metrics-Alert-Definition class extends Alert-Definition class: > // either jmx or ganglia will exist > * jmx (Alert-Metrics-source-Definition) > * ganglia (Alert-Metrics-source-Definition) > * uri (string) > * reporting (Alert-Report-Definition[]) > > Aggregate-Alert-Definition class extends Alert-Definition class: > * alertName (string) > * reporting (Alert-Report-Definition[]) > > Script-Alert-Definition}} class extends Alert-Definition class: > * location (string) //a path > * reporting (Alert-Report-Definition[]) > > > Diffs > ----- > > ambari-web/app/models.js 130f526 > ambari-web/app/models/alertDefinition.js PRE-CREATION > > Diff: https://reviews.apache.org/r/27229/diff/ > > > Testing > ------- > > > Thanks, > > Aleksandr Kovalenko > >
