----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27206/#review58645 -----------------------------------------------------------
Python should get unit tests too. Also, a lot of file-writing operations have already been written, can any of those be used? ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml <https://reviews.apache.org/r/27206/#comment99703> Should be 2 space indent ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_client.py <https://reviews.apache.org/r/27206/#comment99704> Does the client require krb5-server? ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py <https://reviews.apache.org/r/27206/#comment99708> There seems to be a lot of these - they're typically pre-determined in a params.py file. Can these not be done like with the other components? ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py <https://reviews.apache.org/r/27206/#comment99709> python doc goes in the method itself ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py <https://reviews.apache.org/r/27206/#comment99711> Can this be abstracted out via params.py? - Nate Cole On Oct. 27, 2014, 10:37 a.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27206/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2014, 10:37 a.m.) > > > Review request for Ambari, Jaimin Jetly, John Speidel, Nate Cole, and Yusaku > Sako. > > > Bugs: AMBARI-7448 > https://issues.apache.org/jira/browse/AMBARI-7448 > > > Repository: ambari > > > Description > ------- > > Create a service to manage the (optional) Kerberos server (managed KDC) and > client components in the HDP 2.2 stack. > > See [Ambari Cluster Kerberization Technical > Document](https://issues.apache.org/jira/secure/attachment/12671235/AmbariClusterKerberization.pdf) > for more information. > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kdc-conf.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/krb5-conf.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_client.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_server.py > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/api/services/KerberosServiceMetaInfoTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/27206/diff/ > > > Testing > ------- > > Added new unit test - > `org.apache.ambari.server.api.services.KerberosServiceMetaInfoTest` > > > Thanks, > > Robert Levas > >
