----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27287/#review58815 -----------------------------------------------------------
Ship it! Ship It! - Oleg Nechiporenko On Oct. 28, 2014, 4:13 p.m., Aleksandr Kovalenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27287/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2014, 4:13 p.m.) > > > Review request for Ambari and Oleg Nechiporenko. > > > Bugs: AMBARI-7984 > https://issues.apache.org/jira/browse/AMBARI-7984 > > > Repository: ambari > > > Description > ------- > > Alerts UI needs to model Alert-Definitions and Alert-Instances as classes. > > Alert-Definition class is: > id (number) > name (string) > label (string) > serviceName (string) > componentName (string) > enabled (boolean) > scope (string) > interval (number) > type (string) // "SCRIPT" | "METRIC" | "AGGREGATE" | "PERCENT" | "PORT" > > Alert-Report-Definition class: > type (string) - OK, Warning, Critical > text (string) > value (number) - may not exist > > Alert-Metrics-Source-Definition class: > propertyList (string[]) > value (string) > > Alert-Metrics-Uri-Definition class: > http (string), > https (string) > https_property (string) > https_property_value (string) > > Port-Alert-Definition class extends Alert-Definition class: > defaultPort (number) > uri (string) > reporting (Alert-Report-Definition[]) > > Metrics-Alert-Definition class extends Alert-Definition class: > // either jmx or ganglia will exist > jmx (Alert-Metrics-source-Definition) > ganglia (Alert-Metrics-source-Definition) > uri (Alert-Metrics-Uri-Definition) > reporting (Alert-Report-Definition[]) > > Aggregate-Alert-Definition class extends Alert-Definition class: > alertName (string) > reporting (Alert-Report-Definition[]) > > Script-Alert-Definition class extends Alert-Definition class: > location (string) //a path > reporting (Alert-Report-Definition[]) > > // newly added type > Web-Alert-Definition class extends Alert-Definition class: > uri (Alert-Metrics-Uri-Definition) > reporting (Alert-Report-Definition[]) > > > Diffs > ----- > > ambari-web/app/models/alertDefinition.js 8ac8878 > > Diff: https://reviews.apache.org/r/27287/diff/ > > > Testing > ------- > > > Thanks, > > Aleksandr Kovalenko > >
