----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27319/#review58976 -----------------------------------------------------------
Ship it! Ship It! - Nate Cole On Oct. 28, 2014, 11:36 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27319/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2014, 11:36 p.m.) > > > Review request for Ambari, Nate Cole and Tom Beerbower. > > > Bugs: AMBARI-8010 > https://issues.apache.org/jira/browse/AMBARI-8010 > > > Repository: ambari > > > Description > ------- > > Flume is unique in that its alerts are currently run by the agents and > injected into the heartbeat back to the server. There are specialized methods > in flume_handler.py and flume.py that parse the flume JSON file and produce > output about the running processes. These methods are also used by the main > service methods (like start and configure) defined in flume.py. > > I have moved the methods with sharable logic into a ambari-common and altered > the flume.py file to use the new shared resources. > > The new alerts also use the shared resources. > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/flume_agent_helper.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/alerts.json > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/files/alert_flume_agent_status.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume.py > 2db4039 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume_handler.py > 42ac560 > ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 85602ef > > Diff: https://reviews.apache.org/r/27319/diff/ > > > Testing > ------- > > - Verified that when flume has no agents, the alert shows as OK > - Verified that multiple agents being in various states correctly trigger > alerts > - Started, stopped flume service/agents and ran a configure to ensure that > existing functionality still works. > > Updated existing flume tests > > ------------------------------------------------------------------------ > Total run:679 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Jonathan Hurley > >
