[ 
https://issues.apache.org/jira/browse/AMBARI-8018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14188488#comment-14188488
 ] 

Hadoop QA commented on AMBARI-8018:
-----------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12677894/AMBARI-8018.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
ambari-server.

Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/402//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/402//console

This message is automatically generated.

> Show all properties for source subresource in alert_definitions API response
> ----------------------------------------------------------------------------
>
>                 Key: AMBARI-8018
>                 URL: https://issues.apache.org/jira/browse/AMBARI-8018
>             Project: Ambari
>          Issue Type: Task
>          Components: alerts, ambari-server
>    Affects Versions: 2.0.0
>            Reporter: Jonathan Hurley
>            Assignee: Jonathan Hurley
>             Fix For: 2.0.0
>
>         Attachments: AMBARI-8018.patch
>
>
> Currently response for 
> http://c6401.ambari.apache.org:8080/api/v1/clusters/c/alert_definitions?fields=*
>  is:
> {code}
> {
>   "href" : 
> "http://c6401.ambari.apache.org:8080/api/v1/clusters/c/alert_definitions?fields=*";,
>   "items" : [
>     {
>       "href" : 
> "http://c6401.ambari.apache.org:8080/api/v1/clusters/c/alert_definitions/1";,
>       "AlertDefinition" : {
>         "cluster_name" : "c",
>         "component_name" : "HISTORYSERVER",
>         "enabled" : true,
>         "id" : 1,
>         "interval" : 1,
>         "label" : "History Server Web UI",
>         "name" : "mapreduce_history_server_webui",
>         "scope" : "ANY",
>         "service_name" : "MAPREDUCE2",
>         "source" : {
>           "type" : "WEB"
>         }
>       }
>     }...
> {code}
> but response for 
> http://c6401.ambari.apache.org:8080/api/v1/clusters/c/alert_definitions/1 is:
> {code}
> {
>   "href" : 
> "http://c6401.ambari.apache.org:8080/api/v1/clusters/c/alert_definitions/1";,
>   "AlertDefinition" : {
>     "cluster_name" : "c",
>     "component_name" : "HISTORYSERVER",
>     "enabled" : true,
>     "id" : 1,
>     "interval" : 1,
>     "label" : "History Server Web UI",
>     "name" : "mapreduce_history_server_webui",
>     "scope" : "ANY",
>     "service_name" : "MAPREDUCE2",
>     "source" : {
>       "reporting" : {
>         "ok" : {
>           "text" : "HTTP {0} response in {3:.4f} seconds"
>         },
>         "warning" : {
>           "text" : "HTTP {0} response in {3:.4f} seconds"
>         },
>         "critical" : {
>           "text" : "Connection failed to {1}:{2}"
>         }
>       },
>       "type" : "WEB",
>       "uri" : {
>         "http" : "{{mapred-site/mapreduce.jobhistory.webapp.address}}",
>         "https" : "{{mapred-site/mapreduce.jobhistory.webapp.https.address}}",
>         "https_property" : "{{mapred-site/mapreduce.jobhistory.http.policy}}",
>         "https_property_value" : "HTTPS_ONLY",
>         "default_port" : 0.0
>       }
>     }
>   }
> }
> {code}
> And for mapping data on UI we need the full source data. Currently we need to 
> make one request for all alert_definitions with all data except source and 
> one request for each alert_definition just to get all source data.
> So after this change only one request will be enough to get all 
> alert_definitions data.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to