----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27471/#review59506 -----------------------------------------------------------
Not a fan of keeping two objects in sync explicitly. Let's use / create a wrapper function. Also, if this is a temporary fix, let's make a comment saying a proper refactor is TODO. - Yusaku Sako On Nov. 1, 2014, 6:48 p.m., Jaimin Jetly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27471/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2014, 6:48 p.m.) > > > Review request for Ambari, Srimanth Gunturi and Yusaku Sako. > > > Bugs: AMBARI-8094 > https://issues.apache.org/jira/browse/AMBARI-8094 > > > Repository: ambari > > > Description > ------- > > STR: > Attempted to deploy a cluster. > Install failed. > Went back to a previous step using the left nav. > It gave me the pop-up warning that I would lose work to date, I said ok, and > it did nothing. The popup went away and the display remained on the Install > Results page. > > > Diffs > ----- > > ambari-web/app/router.js 97fc560 > ambari-web/app/routes/installer.js 5c164fe > > Diff: https://reviews.apache.org/r/27471/diff/ > > > Testing > ------- > > tested e2e on the cluster that had the repro for this issue > > > Thanks, > > Jaimin Jetly > >
