----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27485/#review59521 -----------------------------------------------------------
Ship it! Ship It! - Nate Cole On Nov. 2, 2014, 12:01 a.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27485/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2014, 12:01 a.m.) > > > Review request for Ambari, Nate Cole and Tom Beerbower. > > > Bugs: AMBARI-8104 > https://issues.apache.org/jira/browse/AMBARI-8104 > > > Repository: ambari > > > Description > ------- > > When running in HA mode, there is a component in HDFS called the ZooKeeper > Failover Controller. This component is installed on machines where the > namenodes run and is a required component for a successful failover. > > A new alert definition was added for ZKFC which will deploy on any host > running a ZKFC. However, the property is a comma-separated list like: > core-site/ha.zookeeper.quorum : > c6401.ambari.apache.org:2181,c6402.ambari.apache.org:2181,c6403.ambari.apache.org:2181 > > PortAlert was altered to see if the supplied propert is a comma-separated > list. If so, it will attempt to match the current host against the parsed > list. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 5152570 > ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py aa75e34 > ambari-agent/src/test/python/ambari_agent/TestAlerts.py 88584db > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/alerts.json > 0a6a455 > > Diff: https://reviews.apache.org/r/27485/diff/ > > > Testing > ------- > > Verified that the new alert is distributed to all hosts running ZKFC and that > the alert reports OK and CRITICAL status; updated tests to exercise new URI > parsing code. > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 11.033 s > [INFO] Finished at: 2014-11-01T15:16:32-04:00 > [INFO] Final Memory: 10M/81M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Jonathan Hurley > >
