> On Nov. 3, 2014, 8:47 p.m., Srimanth Gunturi wrote: > > The debug statements were removed. Is it known that the usage of stream > > will definitely fix this issue? If it happens again, the debugs might be > > helpful.
Actually I only removed the opening and closing stream DEBUG statements. Once I saw that the entries were actaully being skipped, I thought that those were overkill. The DEBUG statments which show which entry is being extracted, the start of the extraction, the end of the extraction and the mkdir are all still in place. - Tom ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27537/#review59634 ----------------------------------------------------------- On Nov. 3, 2014, 8:25 p.m., Tom Beerbower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27537/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2014, 8:25 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Srimanth Gunturi. > > > Bugs: AMBARI-8125 > https://issues.apache.org/jira/browse/AMBARI-8125 > > > Repository: ambari > > > Description > ------- > > Intermittent problem where view.xml (and other files) is missing from > extracted view directory. > > If the view.xml is missing then the resulting exception will look like ... > > {code} > 07:17:13,542 ERROR [main] ViewRegistry:1314 - Caught exception loading view > SLIDER{1.0.0} > java.io.FileNotFoundException: > /var/lib/ambari-server/resources/views/work/SLIDER{1.0.0}/view.xml (No such > file or directory) > at java.io.FileInputStream.open(Native Method) > at java.io.FileInputStream.<init>(FileInputStream.java:146) > at > org.apache.ambari.server.view.ViewArchiveUtility.getViewConfigFromExtractedArchive(ViewArchiveUtility.java:81) > at > org.apache.ambari.server.view.ViewRegistry.readViewArchive(ViewRegistry.java:1287) > at > org.apache.ambari.server.view.ViewRegistry.readViewArchives(ViewRegistry.java:1239) > at > org.apache.ambari.server.view.ViewRegistry.readViewArchives(ViewRegistry.java:430) > at > org.apache.ambari.server.controller.AmbariServer.run(AmbariServer.java:333) > at > org.apache.ambari.server.controller.AmbariServer.main(AmbariServer.java:648) > {code} > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewArchiveUtility.java > 950f552 > > ambari-server/src/main/java/org/apache/ambari/server/view/ViewExtractor.java > cd17404 > > ambari-server/src/test/java/org/apache/ambari/server/view/ViewExtractorTest.java > b66714e > > ambari-server/src/test/java/org/apache/ambari/server/view/ViewRegistryTest.java > 1d98b6c > > Diff: https://reviews.apache.org/r/27537/diff/ > > > Testing > ------- > > Tested locally to make sure that extraction process works. Have not been > able to reproduce the original issue. > > Updated existing unit tests. All tests ... > > Results : > > Tests run: 2192, Failures: 0, Errors: 0, Skipped: 14 > > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 34:45 min > [INFO] Finished at: 2014-11-03T15:07:47-05:00 > [INFO] Final Memory: 39M/319M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Tom Beerbower > >
