----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27547/#review59696 -----------------------------------------------------------
ambari-web/app/utils/config.js <https://reviews.apache.org/r/27547/#comment100991> The function being called takes "advancedConfigs" but this is passing configGroups. Is this intended? ambari-web/app/utils/config.js <https://reviews.apache.org/r/27547/#comment100992> Method names should start with a lower-case letter. Also, onX naming implies that it is a callback function. Can we rename this to updateNnHAProperties or something along that line? Can you link to this ReviewBoard from the Ambari JIRA? - Yusaku Sako On Nov. 3, 2014, 11:31 p.m., Xi Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27547/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2014, 11:31 p.m.) > > > Review request for Ambari, Jaimin Jetly and Yusaku Sako. > > > Bugs: Ambari-8129 > https://issues.apache.org/jira/browse/Ambari-8129 > > > Repository: ambari > > > Description > ------- > > hdfs-site.xml > Change value of "dfs.namenode.safemode.threshold-pct" to "0.99f" if NN HA > > > Diffs > ----- > > ambari-web/app/utils/config.js 2f157e8 > > Diff: https://reviews.apache.org/r/27547/diff/ > > > Testing > ------- > > Tested patch before/after NN HA enabled. Unit tests passed. > > > Thanks, > > Xi Wang > >
