> On Лис. 4, 2014, 8:04 після полудня, Jayush Luniya wrote: > > ambari-web/app/controllers/main/service/info/configs.js, line 262 > > <https://reviews.apache.org/r/27540/diff/1/?file=747797#file747797line262> > > > > Can you also add error callback loadClusterEnvSiteError?
Basically if we do not specify error handler function for App.ajax, the default handler will be used (defaultErrorHandler from ambari-web/app/utils/ajax/ajax.js). It shows alert popup with error details from request response. So as we don't need any specific logic to handle errors I just skip custom error handler. But if we need some specific logic to handle errors, I can add custom handler. - Aleksandr ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27540/#review59817 ----------------------------------------------------------- On Лис. 4, 2014, 7:36 після полудня, Artem Baranchuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27540/ > ----------------------------------------------------------- > > (Updated Лис. 4, 2014, 7:36 після полудня) > > > Review request for Ambari, Aleksandr Kovalenko, Florian Barca, Jayush Luniya, > and Mahadev Konar. > > > Bugs: AMBARI-8120 > https://issues.apache.org/jira/browse/AMBARI-8120 > > > Repository: ambari > > > Description > ------- > > AMBARI-8120 - Configs tab doesn't appear for all services > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/configuration-mapred/mapred-site.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/configuration/mapred-site.xml > 8e909bc > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/YARN/metainfo.xml > 31eb346 > ambari-web/app/assets/data/configuration/cluster_env_site.json PRE-CREATION > ambari-web/app/controllers/main/service/info/configs.js c9ec483 > ambari-web/app/utils/ajax/ajax.js f264dc4 > > Diff: https://reviews.apache.org/r/27540/diff/ > > > Testing > ------- > > [INFO] Ambari Server ..................................... SUCCESS > [28:51.093s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Artem Baranchuk > >
