----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27626/#review59984 -----------------------------------------------------------
Ship it! Ship It! - Oleg Nechiporenko On Nov. 5, 2014, 5:39 p.m., Aleksandr Kovalenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27626/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2014, 5:39 p.m.) > > > Review request for Ambari and Oleg Nechiporenko. > > > Bugs: AMBARI-8161 > https://issues.apache.org/jira/browse/AMBARI-8161 > > > Repository: ambari > > > Description > ------- > > We have to create the main Alert Definition page for an alert definition. > This page will be entered from the Alerts summary page, and will have inline > edit along with actions to Enable/Disable and Delete. > > Clicking on instance should route to host level alerts page. > > > Diffs > ----- > > ambari-web/app/controllers.js 6924ccf > ambari-web/app/controllers/main/alert_definitions_controller.js d41ff91 > > ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js > e5c9568 > ambari-web/app/controllers/main/alerts/definition_details_controller.js > PRE-CREATION > ambari-web/app/messages.js 6625a38 > ambari-web/app/models.js 14f3249 > ambari-web/app/models/alertDefinition.js e5441ea > ambari-web/app/models/alert_definition.js PRE-CREATION > ambari-web/app/models/alert_instance.js ccb5cc1 > ambari-web/app/routes/main.js 787e1db > ambari-web/app/styles/alerts.less d263f54 > ambari-web/app/templates/main/alerts.hbs 07cb3d4 > ambari-web/app/templates/main/alerts/definition_details.hbs PRE-CREATION > ambari-web/app/views.js 842181a > ambari-web/app/views/main/alert_definitions_view.js 22272ea > ambari-web/app/views/main/alerts/definition_details_view.js PRE-CREATION > > Diff: https://reviews.apache.org/r/27626/diff/ > > > Testing > ------- > > 4919 tests complete (6 seconds) > 60 tests pending > > > Thanks, > > Aleksandr Kovalenko > >
