----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27607/#review59994 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java <https://reviews.apache.org/r/27607/#comment101316> Totally right, will fix this in the next patch. ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java <https://reviews.apache.org/r/27607/#comment101317> Ok, I'll remove it. ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java <https://reviews.apache.org/r/27607/#comment101318> Will do, thanks. ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java <https://reviews.apache.org/r/27607/#comment101319> I'll remove that annotation in the next patch. ambari-server/src/main/java/org/apache/ambari/server/state/ClusterVersionState.java <https://reviews.apache.org/r/27607/#comment101320> Thanks for the tip; I'll improve this java doc and move it to the top. ambari-server/src/main/java/org/apache/ambari/server/state/HostComponentUpgradeState.java <https://reviews.apache.org/r/27607/#comment101321> Will do. ambari-server/src/main/java/org/apache/ambari/server/state/HostVersionState.java <https://reviews.apache.org/r/27607/#comment101322> I'll move this to the top with the rest of the java doc and add <pre> tags. ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java <https://reviews.apache.org/r/27607/#comment101325> Will do. ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java <https://reviews.apache.org/r/27607/#comment101326> Will do, I'll add a method just for Rolling Upgrades. ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql <https://reviews.apache.org/r/27607/#comment101329> I'm following the existing convention, but I can certainly change the new tables to use "_" and break up the CREATE TABLE statement into multiple lines. ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql <https://reviews.apache.org/r/27607/#comment101330> Thanks, I'll change it to 0. ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql <https://reviews.apache.org/r/27607/#comment101331> Will change it to long. - Alejandro Fernandez On Nov. 5, 2014, 4:30 a.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27607/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2014, 4:30 a.m.) > > > Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, Nate Cole, > Sid Wagle, and Yurii Shylov. > > > Bugs: AMBARI-8148 > https://issues.apache.org/jira/browse/AMBARI-8148 > > > Repository: ambari > > > Description > ------- > > 1. Create new tables and populate during the installation of a new cluster. > > *clusterversion* table > Column | Type | Keys | Example > ----------|------------|------|--------------------------------------------- > id |BIGINT |PK |1 > cluster_id|BIGINT |FK |2 > stack |VARCHAR(255)| |HDP-2.2 > version |VARCHAR(255)| |HDP-2-2.0.1-885 > state |VARCHAR(32) | |INSTALLED, CURRENT, UPGRADING, UPGRADE_FAILED > start_time|DATETIME | |2014-10-31 14:00:00 > end_time |DATETIME | |2014-10-31 15:00:00 > user_name |VARCHAR(32) | |admin > > *hostcomponentstate* table > Add column upgrade_state VARCHAR(32) ("NONE" is the default, "UPGRADING", > "UPGRADE_FAILED") > > *hostversion* table > Column |Type |Keys |Example > ---------|------------|-------------|---------------------------------- > id |BIGINT |PK |1 > host_name|VARCHAR(255)|FK hosts.name|c6401.ambari.apache.org > stack |VARCHAR(255)| |HDP-2.2 > version |VARCHAR(255)| |2.2.0.1-885 > state |VARCHAR(32) | |INSTALLED, CURRENT, NOT_INSTALLED > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java > b030ea1 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java > 7dce204 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostEntity.java > a71fddb > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/state/ClusterVersionState.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/state/HostComponentUpgradeState.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/state/HostVersionState.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java > 3718556 > > ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java > bc97936 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java > 14c385d > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 9054b3f > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql abe8b39 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 0bea067 > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql > ebc8f5c > ambari-server/src/main/resources/META-INF/persistence.xml 2d8fedb > ambari-server/src/test/python/TestAmbariServer.py c3651eb > > Diff: https://reviews.apache.org/r/27607/diff/ > > > Testing > ------- > > Ran unit tests > > ambari-server unit tests > ---------------------------------------------------------------------- > Total run:684 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Alejandro Fernandez > >
