> On Nov. 7, 2014, 10:23 a.m., Tom Beerbower wrote: > > ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java, > > lines 28-34 > > <https://reviews.apache.org/r/27696/diff/1/?file=751920#file751920line28> > > > > I also use the IntelliJ default generated order which puts the > > java/javax last. The rest is just alphabetical... so com, org, java. Do > > we have a standard for import order or is it really IntelliJ default vs. > > Eclipse default?
Hmm, perhaps. I'm SURE we don't have any guidelines on this. Eclipse's ordering is based on java/javax (part of jdk) then org (usually open source libraries) then com (internal development). I can withdraw the comment in favor of hassle-factor :) - Nate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27696/#review60317 ----------------------------------------------------------- On Nov. 6, 2014, 2:59 p.m., John Speidel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27696/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2014, 2:59 p.m.) > > > Review request for Ambari, Nate Cole and Tom Beerbower. > > > Bugs: AMBARI-7175 > https://issues.apache.org/jira/browse/AMBARI-7175 > > > Repository: ambari > > > Description > ------- > > Adds Explicit Stack Service Inheritance functionality. > Also contains major refactoring of existing Stack related functionality. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/ObjectNotFoundException.java > 138774a > > ambari-server/src/main/java/org/apache/ambari/server/ParentObjectNotFoundException.java > 98d60d5 > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java > e99e39f > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java > c39ba29 > > ambari-server/src/main/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRenderer.java > 847735d > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java > 3d67fe9 > > ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java > 781ea13 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java > 4808a77 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > 8ffad0d > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 4f69dbb > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java > a8e3451 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractResourceProvider.java > 2c25623 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java > 94c0d58 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java > 96b4c8c > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java > 9a2be41 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java > 31c6c37 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/Stack.java > d6cfbd0 > > ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandOrder.java > 3427f9a > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintEntity.java > 20ac03f > ambari-server/src/main/java/org/apache/ambari/server/stack/BaseModule.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/stack/ConfigurationDirectory.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/stack/ConfigurationInfo.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/stack/ConfigurationModule.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/stack/ModuleFileUnmarshaller.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/stack/StackContext.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/stack/StackDefinitionDirectory.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/stack/StackDefinitionModule.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java > PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/state/AutoDeployInfo.java > 9e97d5f > > ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java > c9794d8 > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java > e15a62a > > ambari-server/src/main/java/org/apache/ambari/server/state/DependencyInfo.java > 58e6e4c > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java > 45ea1f9 > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java > bb5057f > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java > ae746d6 > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceOsSpecific.java > a143ba1 > ambari-server/src/main/java/org/apache/ambari/server/state/Stack.java > 92b799d > ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java > 242cfcc > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > d22e250 > > ambari-server/src/test/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRendererTest.java > 6e58267 > > ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java > e7b946d > > ambari-server/src/test/java/org/apache/ambari/server/api/util/StackExtensionHelperTest.java > f05aab5 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java > 5c8b4ad > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > b2c023f > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java > 5438654 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java > d73eea4 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java > 98bd017 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java > 1455c52 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java > 2879094 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java > 05f2e01 > > ambari-server/src/test/java/org/apache/ambari/server/orm/entities/BlueprintEntityTest.java > d8c0e29 > > ambari-server/src/test/java/org/apache/ambari/server/stack/ComponentModuleTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/stack/ServiceModuleTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/state/PropertyInfoTest.java > c4eff8c > ambari-server/src/test/resources/bad-stacks/HDP/0.1/repos/repoinfo.xml > 9ea91b8 > > ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/metainfo.xml > 3bfd4f7 > > ambari-server/src/test/resources/stacks/HDP/2.0.7/services/YARN/metainfo.xml > 08f9949 > > ambari-server/src/test/resources/stacks/HDP/2.0.8/services/HBASE/configuration/hbase-site.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks/HDP/2.0.8/services/HBASE/metainfo.xml > 336701a > ambari-server/src/test/resources/stacks/HDP/2.1.1/services/PIG/metainfo.xml > 50d3146 > ambari-server/src/test/resources/stacks/OTHER/1.0/metainfo.xml PRE-CREATION > ambari-server/src/test/resources/stacks/OTHER/1.0/repos/hdp.json > PRE-CREATION > ambari-server/src/test/resources/stacks/OTHER/1.0/repos/repoinfo.xml > PRE-CREATION > ambari-server/src/test/resources/stacks/OTHER/1.0/role_command_order.json > PRE-CREATION > > ambari-server/src/test/resources/stacks/OTHER/1.0/services/HDFS/configuration/hdfs-site.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks/OTHER/1.0/services/HDFS/metainfo.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks/OTHER/1.0/services/HDFS/metrics.json > PRE-CREATION > > ambari-server/src/test/resources/stacks/OTHER/1.0/services/HDFS/package/dummy-script.py > PRE-CREATION > > ambari-server/src/test/resources/stacks/OTHER/1.0/services/SQOOP2/metainfo.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks/OTHER/1.0/services/STORM/configuration/placeholder.txt > PRE-CREATION > > ambari-server/src/test/resources/stacks/OTHER/1.0/services/STORM/metainfo.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks/OTHER/1.0/services/STORM/metrics.json > PRE-CREATION > > ambari-server/src/test/resources/stacks/OTHER/1.0/services/STORM/package/placeholder.txt > PRE-CREATION > ambari-server/src/test/resources/stacks/OTHER/2.0/metainfo.xml PRE-CREATION > ambari-server/src/test/resources/stacks/OTHER/2.0/repos/hdp.json > PRE-CREATION > ambari-server/src/test/resources/stacks/OTHER/2.0/repos/repoinfo.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks/OTHER/2.0/services/HBASE/metainfo.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks/OTHER/2.0/services/SQOOP2/metainfo.xml > PRE-CREATION > ambari-server/src/test/resources/stacks_with_cycle/OTHER/1.0/metainfo.xml > PRE-CREATION > ambari-server/src/test/resources/stacks_with_cycle/OTHER/1.0/repos/hdp.json > PRE-CREATION > > ambari-server/src/test/resources/stacks_with_cycle/OTHER/1.0/repos/repoinfo.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks_with_cycle/OTHER/1.0/role_command_order.json > PRE-CREATION > > ambari-server/src/test/resources/stacks_with_cycle/OTHER/1.0/services/HDFS/configuration/hdfs-site.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks_with_cycle/OTHER/1.0/services/HDFS/metainfo.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks_with_cycle/OTHER/1.0/services/HDFS/metrics.json > PRE-CREATION > > ambari-server/src/test/resources/stacks_with_cycle/OTHER/1.0/services/HDFS/package/dummy-script.py > PRE-CREATION > > ambari-server/src/test/resources/stacks_with_cycle/OTHER/1.0/services/SQOOP2/metainfo.xml > PRE-CREATION > ambari-server/src/test/resources/stacks_with_cycle/OTHER/2.0/metainfo.xml > PRE-CREATION > ambari-server/src/test/resources/stacks_with_cycle/OTHER/2.0/repos/hdp.json > PRE-CREATION > > ambari-server/src/test/resources/stacks_with_cycle/OTHER/2.0/repos/repoinfo.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks_with_cycle/OTHER/2.0/services/SQOOP2/metainfo.xml > PRE-CREATION > ambari-server/src/test/resources/stacks_with_cycle2/stack1/1.0/metainfo.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks_with_cycle2/stack1/1.0/repos/hdp.json > PRE-CREATION > > ambari-server/src/test/resources/stacks_with_cycle2/stack1/1.0/repos/repoinfo.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks_with_cycle2/stack1/1.0/services/HDFS/metainfo.xml > PRE-CREATION > ambari-server/src/test/resources/stacks_with_cycle2/stack2/1.0/metainfo.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks_with_cycle2/stack2/1.0/repos/hdp.json > PRE-CREATION > > ambari-server/src/test/resources/stacks_with_cycle2/stack2/1.0/repos/repoinfo.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks_with_cycle2/stack2/1.0/services/HDFS/metainfo.xml > PRE-CREATION > ambari-server/src/test/resources/stacks_with_cycle2/stack3/1.0/metainfo.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks_with_cycle2/stack3/1.0/repos/hdp.json > PRE-CREATION > > ambari-server/src/test/resources/stacks_with_cycle2/stack3/1.0/repos/repoinfo.xml > PRE-CREATION > > ambari-server/src/test/resources/stacks_with_cycle2/stack3/1.0/services/HDFS/metainfo.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/27696/diff/ > > > Testing > ------- > > All existing unit tests pass. > Added many new unit tests. > > Results : > Tests run: 2222, Failures: 0, Errors: 0, Skipped: 14 > ... > Total run:684 > Total errors:0 > Total failures:0 > > > Thanks, > > John Speidel > >
