----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27766/#review60455 -----------------------------------------------------------
Ship it! Ship It! - Mahadev Konar On Nov. 8, 2014, 1:44 a.m., John Speidel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27766/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2014, 1:44 a.m.) > > > Review request for Ambari, Mahadev Konar and Sid Wagle. > > > Bugs: AMBARI-8226 > https://issues.apache.org/jira/browse/AMBARI-8226 > > > Repository: ambari > > > Description > ------- > > In some cases, configuration properties that are marked as topology > properties in the blueprint config processor, contain 'undefined' instead of > an actual hostname. > The three properties mentioned in the summary fall into this category if > storm is deployed without Ganglia. > For example, here is the value of nimbus.childopts: > "-Xmx1024m -Djava.security.auth.login.config=/etc/storm/conf/storm_jaas.conf > -javaagent:/usr/lib/storm/contrib/storm-jmxetric/lib/jmxetric-1.0.4.jar=host=undefined,port=8649,wireformat31x=true,mode=multicast,config=/usr/lib/storm/contrib/storm-jmxetric/conf/jmxetric-conf.xml,process=Nimbus_JVM" > Because the BP processor didn't match any cluster host to a portion of the > property value, it determined that this property must point to an external > host and doesn't export the property. > > In the future the BP processor needs to be smarter about this but for now if > a topology related property doesn't match to any host but contains > 'undefined', the property is exported. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > 5af81be > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java > 6c00927 > > Diff: https://reviews.apache.org/r/27766/diff/ > > > Testing > ------- > > All unit tests pass. > Added new unit test. > > > Thanks, > > John Speidel > >
