> On Nov. 12, 2014, 12:17 a.m., Yusaku Sako wrote: > > ambari-web/app/controllers/global/cluster_controller.js, line 332 > > <https://reviews.apache.org/r/27893/diff/1/?file=758474#file758474line332> > > > > Did you intend to remove this?
No. this was an unintended change happened while merging my stashed work with the remote changes. Thanks for pointing this out. I have submitted another patch with the fix - Jaimin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27893/#review60901 ----------------------------------------------------------- On Nov. 12, 2014, 12:36 a.m., Jaimin Jetly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27893/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2014, 12:36 a.m.) > > > Review request for Ambari, Srimanth Gunturi and Yusaku Sako. > > > Bugs: AMBARI-8291 > https://issues.apache.org/jira/browse/AMBARI-8291 > > > Repository: ambari > > > Description > ------- > > Create a RootService model and RootServicecomponent model. > For now lets skip providing RootServiceHostComponent model. > This task is mainly required to access ambari-server properties file > configuration in client code. > (Example: knowing the jdk and jce used by the ambari server instance). > > > Diffs > ----- > > ambari-web/app/assets/data/services/ambari.json PRE-CREATION > ambari-web/app/controllers/global/cluster_controller.js c405c0d > ambari-web/app/mappers.js 2f974df > ambari-web/app/mappers/root_service_mapper.js PRE-CREATION > ambari-web/app/models.js df19e28 > ambari-web/app/models/root_service.js PRE-CREATION > ambari-web/app/utils/ajax/ajax.js ef26ba8 > > Diff: https://reviews.apache.org/r/27893/diff/ > > > Testing > ------- > > tested e2e > > > Thanks, > > Jaimin Jetly > >
