> On Ноя. 12, 2014, 7:26 п.п., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java, > > line 219 > > <https://reviews.apache.org/r/27819/diff/2/?file=759519#file759519line219> > > > > If they only update the Display Name, even though that Repo Version is > > installed in clusters, I believe that operation should be allowed.
Check the if block at lines 211-212, we won't enter it if the only updated value will be Display Name - Yurii ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27819/#review61033 ----------------------------------------------------------- On Ноя. 12, 2014, 11:10 д.п., Yurii Shylov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27819/ > ----------------------------------------------------------- > > (Updated Ноя. 12, 2014, 11:10 д.п.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate > Cole. > > > Bugs: AMBARI-8211 > https://issues.apache.org/jira/browse/AMBARI-8211 > > > Repository: ambari > > > Description > ------- > > Create the following API: DELETE /api/v1/repository_versions/1 > PUT /api/v1/repository_versions/1 > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/RepositoryVersionService.java > f9e8885 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java > 6fb1448 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java > b39497c > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/CrudDAO.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java > f0dcb44 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java > 46476da > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java > 8e14bc1 > > ambari-server/src/test/java/org/apache/ambari/server/api/services/RepositoryVersionServiceTest.java > 94b4963 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java > 9dc4996 > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java > 15fcb41 > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/CrudDAOTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAOTest.java > 7dd3fab > > Diff: https://reviews.apache.org/r/27819/diff/ > > > Testing > ------- > > Total run:693 > Total errors:0 > Total failures:0 > > Results : > > Tests run: 2218, Failures: 0, Errors: 0, Skipped: 14 > > > Thanks, > > Yurii Shylov > >
