[
https://issues.apache.org/jira/browse/AMBARI-8310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14209972#comment-14209972
]
Hadoop QA commented on AMBARI-8310:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12681349/AMBARI-8310.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/Ambari-trunk-test-patch/632//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/632//console
This message is automatically generated.
> Ambari Web: convert non-async AJAX calls to async
> -------------------------------------------------
>
> Key: AMBARI-8310
> URL: https://issues.apache.org/jira/browse/AMBARI-8310
> Project: Ambari
> Issue Type: Bug
> Components: ambari-web
> Affects Versions: 1.7.0
> Reporter: Antonenko Alexander
> Assignee: Antonenko Alexander
> Priority: Critical
> Fix For: 2.0.0
>
> Attachments: AMBARI-8310.patch
>
>
> We removed most of non-async calls, but there's a few that still need to be
> converted.
> Non-async calls are problematic. If the request is not satisfied for
> whatever reason - say wifi drops, it completely blocks the browser tab (you
> cannot even close the browser tab in Chrome):
> ambari-web/app/controllers/wizard.js:
> loadServiceComponents: function () {
> return App.ajax.send({
> name: 'wizard.service_components',
> sender: this,
> data: {
> stackUrl: App.get('stackVersionURL'),
> stackVersion: App.get('currentStackVersionNumber'),
> async: false
> },
> success: 'loadServiceComponentsSuccessCallback',
> error: 'loadServiceComponentsErrorCallback'
> });
> },
> ambari-web/app/utils/ajax/ajax.js:
> 'router.authentication': {
> 'real': '/clusters?fields=Clusters/provisioning_state',
> 'mock': '/data/clusters/info.json',
> 'format': function() {
> return {
> async: false
> };
> }
> },
> ambari-web/app/utils/polling.js:
> setRequestId: function () {
> if (App.get('testMode')) {
> this.set('requestId', '1');
> this.doPolling();
> return;
> }
> var self = this;
> var url = this.get('url');
> var method = 'PUT';
> var data = this.get('data');
> $.ajax({
> type: method,
> url: url,
> async: false,
> data: data,
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
