> On Nov. 13, 2014, 4:11 p.m., Jaimin Jetly wrote: > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py, > > lines 177-181 > > <https://reviews.apache.org/r/27206/diff/7/?file=762180#file762180line177> > > > > -norandkey is not supported with the older version of the kerberos. Is > > code taking care of this ?
`-norandkey` would only be used if no administrator credentials were supplied triggering `kadmin.local` to be used rather than `kadmin`. The case would only successfully occur if a managed KDC was being used, and we know this is a newever version of the KDC implementation. On top of that, these peice of code would rarely be executed since most keytabs would be generated on the Ambari Server, not on the agent side. This code would only get executed in the case where a managed KDC was being installed and we needed to create the administrative credentials. - Robert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27206/#review61316 ----------------------------------------------------------- On Nov. 13, 2014, 8:29 a.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27206/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2014, 8:29 a.m.) > > > Review request for Ambari, dilli dorai, Jaimin Jetly, John Speidel, Nate > Cole, Robert Nettleton, and Yusaku Sako. > > > Bugs: AMBARI-7448 > https://issues.apache.org/jira/browse/AMBARI-7448 > > > Repository: ambari > > > Description > ------- > > Create a service to manage the (optional) Kerberos server (managed KDC) and > client components in the HDP 2.2 stack. > > See [Ambari Cluster Kerberization Technical > Document](https://issues.apache.org/jira/secure/attachment/12671235/AmbariClusterKerberization.pdf) > for more information. > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/Role.java 2de7ade > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kadm5-acl.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/kdc-conf.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/configuration/krb5-conf.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_client.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_common.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/kerberos_server.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/params.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/service_check.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/utils.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/templates/kadm5_acl.j2 > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/templates/kdc_conf.j2 > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/templates/krb5_conf.j2 > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/api/services/KerberosServiceMetaInfoTest.java > PRE-CREATION > ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_server.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.2/KERBEROS/use_cases.py PRE-CREATION > > Diff: https://reviews.apache.org/r/27206/diff/ > > > Testing > ------- > > Tests run: 2248, Failures: 0, Errors: 0, Skipped: 14 > > Running tests for stack:2.2 service:KERBEROS > test_configure_cross_realm_trust (test_kerberos_client.TestKerberosClient) > ... ok > test_configure_managed_kdc (test_kerberos_client.TestKerberosClient) ... ok > test_configure_unmanaged_ad (test_kerberos_client.TestKerberosClient) ... ok > test_configure_unmanaged_kdc (test_kerberos_client.TestKerberosClient) ... ok > test_configure_cross_realm_trust (test_kerberos_server.TestKerberosServer) > ... ok > test_configure_managed_kdc (test_kerberos_server.TestKerberosServer) ... ok > test_configure_unmanaged_ad (test_kerberos_server.TestKerberosServer) ... ok > test_configure_unmanaged_kdc (test_kerberos_server.TestKerberosServer) ... ok > > ---------------------------------------------------------------------- > Ran 8 tests in 0.151s > > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 36:44 min > [INFO] Finished at: 2014-11-13T12:28:08+00:00 > [INFO] Final Memory: 41M/412M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Robert Levas > >
