-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28031/
-----------------------------------------------------------
(Updated Nov. 14, 2014, 11:15 a.m.)
Review request for Ambari, Jonathan Hurley and John Speidel.
Changes
-------
changed upgrade to 2.0.0
Bugs: AMBARI-8330
https://issues.apache.org/jira/browse/AMBARI-8330
Repository: ambari
Description
-------
The admin view appears to be passing in string "null" for empty fields in the
create instance portion. We need to get null values, not string with value
"null".
So, we need some mechanism to distinguish between empty string and null value.
It looks like this isn't a view issue but a problem with the API framework.
Patch fixes the issue with the API framework and changes the SQL scripts to
allow null values for the view properties and instance data.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/parsers/JsonRequestBodyParser.java
bbe7647
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java
8250e83
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql ca86e20
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 0c99cd2
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 4c5b89d
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql
7aa7cab
ambari-server/src/test/java/org/apache/ambari/server/api/services/parsers/JsonRequestBodyParserTest.java
1c28452
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java
f9f2708
Diff: https://reviews.apache.org/r/28031/diff/
Testing
-------
Manual test.
All tests pass.
Results :
Tests run: 2112, Failures: 0, Errors: 0, Skipped: 15
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:00 min
[INFO] Finished at: 2014-11-13T17:18:03-05:00
[INFO] Final Memory: 29M/265M
[INFO] ------------------------------------------------------------------------
Thanks,
Tom Beerbower
