----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28105/#review61688 -----------------------------------------------------------
Ship it! Ship It! - Nate Cole On Nov. 16, 2014, 8:54 a.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28105/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2014, 8:54 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Nate Cole, and Tom Beerbower. > > > Bugs: AMBARI-8344 > https://issues.apache.org/jira/browse/AMBARI-8344 > > > Repository: ambari > > > Description > ------- > > With Nagios as the alerting system, Flume alerts needed to be injected into > the response of the status command and manually inserted into the list of > cluster alerts. > > The new alerting system removes the need for this workaround since a single > flume script is now used to check and report on the overall flume state. > > The following areas of code should be removed: > 1) Remove the alerts from the {{status}} function of {{flume_handler.py}} > 2) Remove the {{AgentAlert}} from the host components > 3) Remove the collection of Alerts from the cluster > > > Diffs > ----- > > ambari-server/src/main/java/org/apache/ambari/server/agent/AgentAlert.java > 8c8bc78 > > ambari-server/src/main/java/org/apache/ambari/server/agent/ComponentStatus.java > 7a0c1c7 > > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java > 82b642b > ambari-server/src/main/java/org/apache/ambari/server/agent/HostStatus.java > c63e018 > ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java > 77ab0eb > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > 30dceb0 > > ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/FLUME/package/scripts/flume_handler.py > 42ac560 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume_handler.py > 7c7d635 > > ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java > 6e78b1d > > ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatMonitor.java > 2a0f3db > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java > 7a09514 > ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 28a0ec9 > > Diff: https://reviews.apache.org/r/28105/diff/ > > > Testing > ------- > > Although `alerts` was removed from the structured output, `processes` was > not. To verify that the web client still was able to report the correct flume > process information I configured 2 different flume agents (netstat and hdfs > file sync). Verifed that start/stopping/killing the agent processes was > correctly reflected in the UI. > > mvn clean test as well. > > > Thanks, > > Jonathan Hurley > >
