> On Nov. 17, 2014, 10:04 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql, line 106 > > <https://reviews.apache.org/r/28095/diff/1/?file=765059#file765059line106> > > > > The MySQL script defaults this value to `OFF`, should this script as > > well? > > Robert Levas wrote: > I agree, but the convention for the rest of the file does not really set > the default values.
I'm not sure what tables you're referencing, but you should definitely try to make the SQL consistent with the JPA model. Many tables are correct in here with their defaults, so I don't see why Kerberos would be different. > On Nov. 17, 2014, 10:04 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java, > > lines 381-382 > > <https://reviews.apache.org/r/28095/diff/1/?file=765055#file765055line381> > > > > I'm wondering what the relationship is between a service's kerberos > > state and that of its components. If I set the Foo service to ENABLED, > > shouldn't all of its components across the various hosts become ENABLED as > > well? > > Robert Levas wrote: > If the service is marked to be Kerberized, all of its components should > be set to be Kerberized as well. However if at the time of Kerberization not > all components for that service are installed, we will need to know how to > set the desired Kerberos state when they are installed. To do this, we will > need to look at the serviceDesiredState table. Should this code not set all of the components that are installed though? You would only kerberize a service after it's been installed. Sure, there can be components added after, but existing components should be automatically marked to match their parent service. - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28095/#review61725 ----------------------------------------------------------- On Nov. 17, 2014, 9:45 a.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28095/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2014, 9:45 a.m.) > > > Review request for Ambari, Jonathan Hurley, John Speidel, Robert Nettleton, > Sid Wagle, and Tom Beerbower. > > > Bugs: AMBARI-8336 > https://issues.apache.org/jira/browse/AMBARI-8336 > > > Repository: ambari > > > Description > ------- > > In order to track which services and components have been or need to be > _Kerberized_ several tables need to be updated with a {{kerberos_state}} > column to contain one the following values: > > * `UNKNOWN` - Indicates the state is unknown > * `OFF` - Indicates the service or component is not or should not be > Kerberized > * `ON` - Indicates the service or component is or should be Kerberized > * `IN_PROGRESS` - Indicates the component is in the process of being > Kerberized > * `ERROR` - Indicates the component cannot or failed to be Kerberized > > The following tables need to be updated: > > * hostcomponentdesiredstate - To indicate whether the component needs > Kerberos added or removed (`OFF`, `ON`) > * hostcomponentstate - To indicate whether the component is currently > configured for Kerberos or not (`OFF`, `IN_PROGRESS`, `ON`, `ERROR`, > `UNKNOWN`) > * servicedesiredstate - To indicate whether the service (and it components) > should or should not be Kerberized (`OFF`, `ON`) > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentDesiredStateEntity.java > 610f77f > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java > 81de777 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceDesiredStateEntity.java > a74b021 > > ambari-server/src/main/java/org/apache/ambari/server/state/KerberosState.java > PRE-CREATION > ambari-server/src/main/java/org/apache/ambari/server/state/Service.java > 4a18c69 > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java > 3142974 > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java > 4b4a305 > > ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java > 606751d > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java > 45e7813 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql b2d9221 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 50f02b8 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql d865161 > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql > 2e110ce > ambari-server/src/test/java/org/apache/ambari/server/state/ServiceTest.java > 493291d > > ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java > 5410ee3 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java > 6a5bab7 > > Diff: https://reviews.apache.org/r/28095/diff/ > > > Testing > ------- > > Java Unit Tests: > Tests run: 2250, Failures: 0, Errors: 0, Skipped: 14 > > Manual tests to verifty tabes are altered and values are updated. > > > Thanks, > > Robert Levas > >
