> On Nov. 17, 2014, 1:37 p.m., Nate Cole wrote: > > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py, > > lines 81-85 > > <https://reviews.apache.org/r/27919/diff/3/?file=763819#file763819line81> > > > > A repo file may contain many, does this need a loop? Do the > > repo_suse_rhel.j2 file need a loop template also? > > Dmitro Lisnichenko wrote: > We decided to have individual files per repo version to avoid significant > modifications to RMF > > Nate Cole wrote: > Correct, but an individual file can have more than one base url > > Dmitro Lisnichenko wrote: > Current RMF implementation does not support defining multiple base urls > per repo file. This change would require adjusting invocations at all stacks > > Nate Cole wrote: > The new file "<version>.repo" needs to look like so: > > [<repo-1-name] > baseurl=http://foo/bar > > [<repo-2-name] > baseurl=http://bar/foo
Makes sense. I'll implement that as a separate jira - Dmitro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27919/#review61718 ----------------------------------------------------------- On Nov. 17, 2014, 5:45 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27919/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2014, 5:45 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Nate Cole, and Yurii Shylov. > > > Bugs: AMBARI-8298 > https://issues.apache.org/jira/browse/AMBARI-8298 > > > Repository: ambari > > > Description > ------- > > Distribute Repositories/Install Components - custom action script > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py > 7b5889c > > ambari-agent/src/test/python/resource_management/TestListAmbariManagedRepos.py > PRE-CREATION > > ambari-common/src/main/python/resource_management/libraries/functions/list_ambari_managed_repos.py > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java > c3057cc > > ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml > cd5d5f7 > ambari-server/src/main/resources/custom_actions/check_host.py > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py > PRE-CREATION > ambari-server/src/main/resources/custom_actions/templates/repo_suse_rhel.j2 > PRE-CREATION > ambari-server/src/main/resources/custom_actions/templates/repo_ubuntu.j2 > PRE-CREATION > ambari-server/src/main/resources/custom_actions/validate_configs.py > ambari-server/src/test/python/TestCheckHost.py d68c903 > ambari-server/src/test/python/custom_actions/TestInstallPackages.py > PRE-CREATION > > ambari-server/src/test/python/custom_actions/configs/install_packages_config.json > PRE-CREATION > ambari-server/src/test/python/stacks/utils/RMFTestCase.py 10865fe > ambari-server/src/test/python/unitTests.py f2ffacb > > Diff: https://reviews.apache.org/r/27919/diff/ > > > Testing > ------- > > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main ....................................... SUCCESS [3.425s] > [INFO] Apache Ambari Project POM ......................... SUCCESS [0.273s] > [INFO] Ambari Web ........................................ SUCCESS [35.742s] > [INFO] Ambari Views ...................................... SUCCESS [0.927s] > [INFO] Ambari Admin View ................................. SUCCESS [9.479s] > [INFO] Ambari Server ..................................... SUCCESS [26.684s] > [INFO] Ambari Agent ...................................... SUCCESS [9.606s] > [INFO] Ambari Client ..................................... SUCCESS [0.042s] > [INFO] Ambari Python Client .............................. SUCCESS [0.276s] > [INFO] Ambari Groovy Client .............................. SUCCESS [1.452s] > [INFO] Ambari Shell ...................................... SUCCESS [0.032s] > [INFO] Ambari Python Shell ............................... SUCCESS [0.045s] > [INFO] Ambari Groovy Shell ............................... SUCCESS [0.583s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 1:29.260s > [INFO] Finished at: Fri Nov 14 20:50:47 FET 2014 > [INFO] Final Memory: 53M/395M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Dmitro Lisnichenko > >
