----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28112/#review61746 -----------------------------------------------------------
Thanks for the review! ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java <https://reviews.apache.org/r/28112/#comment103641> Absolutely, this is leftover from all the experimentation ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ManualTask.java <https://reviews.apache.org/r/28112/#comment103625> It can't be inlined because it needs to be serialized into JSON, and for that I need the field. Actually, this is a bug in PERCENT that it _shouldn't_ be in lined. - Nate Cole On Nov. 17, 2014, 6:49 a.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28112/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2014, 6:49 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Yurii > Shylov. > > > Bugs: AMBARI-8346 > https://issues.apache.org/jira/browse/AMBARI-8346 > > > Repository: ambari > > > Description > ------- > > Added schema and altered code and tests to support creating line-items for an > upgrade > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java > baf7401 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > d4d20fd > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/UpgradeDAO.java > 55904f3 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeEntity.java > 912f2cf > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/UpgradeItemEntity.java > d3376dd > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > 30dceb0 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigureTask.java > a4b2fc5 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ExecuteTask.java > 2677d7c > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ManualTask.java > ee92394 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/PercentBatch.java > 2c3604e > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java > 3ebde36 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java > 45e7813 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql b2d9221 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 50f02b8 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql d865161 > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql > 2e110ce > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql d1b6435 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-DROP.sql 203db3a > ambari-server/src/main/resources/META-INF/persistence.xml 0efba2d > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml > ec402c0 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java > 194f424 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java > 6a5bab7 > > Diff: https://reviews.apache.org/r/28112/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 18:25.681s > [INFO] Finished at: Sun Nov 16 19:54:21 EST 2014 > [INFO] Final Memory: 29M/629M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
