-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28123/
-----------------------------------------------------------
(Updated Nov. 17, 2014, 3:43 p.m.)
Review request for Ambari, Nate Cole and Tom Beerbower.
Bugs: AMBARI-8352
https://issues.apache.org/jira/browse/AMBARI-8352
Repository: ambari
Description
-------
When requesting a collection of alert groups via
{{api/v1/clusters/c1/alert_groups}}, the alert definitions that are associated
with that group should be a field that is also returned.
```
http://localhost:8080/api/v1/clusters/c1/alert_groups?fields=AlertGroup/definitions
{
"href" :
"http://localhost:8080/api/v1/clusters/c1/alert_groups?fields=AlertGroup/definitions";,
"items" : [
{
"href" : "http://localhost:8080/api/v1/clusters/c1/alert_groups/1";,
"AlertGroup" : {
"cluster_name" : "c1",
"definitions" : [
{
"name" : "ganglia_monitor_mapreduce_history_server",
"label" : "Ganglia History Server Process Monitor",
"enabled" : true,
"service_name" : "GANGLIA",
"component_name" : "GANGLIA_SERVER",
"id" : 1
},
{
"name" : "ganglia_monitor_yarn_resourcemanager",
"label" : "Ganglia ResourceManager Process Monitor",
"enabled" : true,
"service_name" : "GANGLIA",
"component_name" : "GANGLIA_SERVER",
"id" : 2
},
{
"name" : "ganglia_monitor_hdfs_namenode",
"label" : "Ganglia NameNode Process Monitor",
"enabled" : true,
"service_name" : "GANGLIA",
"component_name" : "GANGLIA_SERVER",
"id" : 3
},
{
"name" : "ganglia_monitor_hbase_master",
"label" : "Ganglia HBase Master Process Monitor",
"enabled" : true,
"service_name" : "GANGLIA",
"component_name" : "GANGLIA_SERVER",
"id" : 4
},
{
"name" : "ganglia_server_process",
"label" : "Ganglia Server Process",
"enabled" : true,
"service_name" : "GANGLIA",
"component_name" : "GANGLIA_SERVER",
"id" : 5
}
],
"id" : 1,
"name" : "GANGLIA"
}
}
]
}
```
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AlertDefinitionResponse.java
26e2f24
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java
0c2fb72
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProviderTest.java
1c85aeb
Diff: https://reviews.apache.org/r/28123/diff/
Testing
-------
New tests added; mvn clean test
Thanks,
Jonathan Hurley
