> On Nov. 17, 2014, 3:08 p.m., John Speidel wrote: > > -1 > > Please dion't merge this. > > > > Please point to a design document for this api addition or documentation > > that describes the details of this api and why it is needed. > > Most of this information is already available via the api. > > > > Also, please include Tom Beerbower in all API related reviews.
John, no this is something different. This effort is to support rolling upgrades of a cluster, where we have to maintain version information for a cluster. In addition, we are also going to be tracking which versions have been installed on hosts. This is a major feature of 2.0.0 and has already been through significant design. Having said that, I've made comments to see if this patch can be simplified a bit. - Nate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28124/#review61787 ----------------------------------------------------------- On Nov. 17, 2014, 1:28 p.m., Yurii Shylov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28124/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2014, 1:28 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate > Cole. > > > Bugs: AMBARI-8353 > https://issues.apache.org/jira/browse/AMBARI-8353 > > > Repository: ambari > > > Description > ------- > > Add stack_versions subresource to /hosts and /clusters > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java > ef907c0 > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterStackVersionResourceDefinition.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostResourceDefinition.java > 14ed799 > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostStackVersionResourceDefinition.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java > 9ad37ec > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java > f75ae11 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java > c51722c > > ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java > 2d91462 > > ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java > 212f944 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java > c198dd6 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java > dbac906 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterVersionDAO.java > e2a2e2d > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostVersionDAO.java > 8d147a1 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterVersionEntity.java > aaf8eed > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostVersionEntity.java > 5b1b4f8 > > ambari-server/src/main/java/org/apache/ambari/server/state/ClusterVersionState.java > 72cd541 > > ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryVersionState.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterResourceDefinitionTest.java > 7296e8d > > ambari-server/src/test/java/org/apache/ambari/server/api/resources/ClusterStackVersionResourceDefinitionTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostResourceDefinitionTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostStackVersionResourceDefinitionTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/api/resources/RepositoryVersionResourceDefinitionTest.java > c0e625a > > ambari-server/src/test/java/org/apache/ambari/server/api/services/ClusterStackVersionServiceTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/api/services/HostStackVersionServiceTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java > e8ce2f7 > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ClusterVersionDAOTest.java > 42bf009 > > ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostVersionDAOTest.java > 93f78b2 > > Diff: https://reviews.apache.org/r/28124/diff/ > > > Testing > ------- > > in progress > > > Thanks, > > Yurii Shylov > >
