----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28224/#review62147 -----------------------------------------------------------
Ship it! Ship It! - Oleg Nechiporenko On Nov. 19, 2014, 11:08 a.m., Andrii Tkach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28224/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2014, 11:08 a.m.) > > > Review request for Ambari and Oleg Nechiporenko. > > > Bugs: AMBARI-8382 > https://issues.apache.org/jira/browse/AMBARI-8382 > > > Repository: ambari > > > Description > ------- > > 1. When clicking on a calendar date, it should dismiss the calendar > 2. If you click ok w/o entering start or end, no error is provided (since > both are required) > 3. Once you do get a custom date filter set, then clear that filter, the > custom option is lost from the dropdown > > > Diffs > ----- > > ambari-web/app/assets/test/tests.js 194a806 > ambari-web/app/controllers/main/dashboard/config_history_controller.js > 97e8b45 > ambari-web/app/templates/common/custom_date_popup.hbs 04c4560 > ambari-web/app/views/common/custom_date_popup.js d018e07 > ambari-web/app/views/common/filter_view.js 3a818d8 > ambari-web/app/views/common/select_custom_date_view.js 55da7fd > ambari-web/app/views/main/dashboard/config_history_view.js a7250ab > ambari-web/test/views/common/custom_date_popup_test.js PRE-CREATION > > Diff: https://reviews.apache.org/r/28224/diff/ > > > Testing > ------- > > 4855 tests complete (8 seconds) > 60 tests pending > > > Thanks, > > Andrii Tkach > >
