-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28095/
-----------------------------------------------------------
(Updated Nov. 21, 2014, 8:46 p.m.)
Review request for Ambari, dilli dorai, Jonathan Hurley, John Speidel, Robert
Nettleton, Sid Wagle, and Tom Beerbower.
Changes
-------
Updated due to review comments.
* Changed Kerberos state to more general security state
* Updated state values to allow for different security types (i.e,
`SECURED_KERBEROS`)
* Updated state values to allow for transitional states (`SECURING`,
`UNSECURING`)
Bugs: AMBARI-8336
https://issues.apache.org/jira/browse/AMBARI-8336
Repository: ambari
Description
-------
In order to track which services and components have been or need to be
secured, several tables need to be updated with a `security_state` column to
contain one the following values:
* `UNKNOWN` - Indicates that it is not known whether the service or component
is secured or not
* `UNSECURED` - Indicates service or component is not or should not be secured
* `SECURED_KERBEROS` - Indicates component is or should be secured using
Kerberos
* `SECURING` - Indicates the component is in the process of being secured
* `UNSECURING` - Indicates the component is in the process of being unsecured
* `ERROR` - Indicates the component is not secured due to an error condition
The following tables need to be updated:
* `hostcomponentdesiredstate` - To indicate whether the component needs
security added or removed
* `hostcomponentstate` - To indicate whether the component is currently
configured for security or not
* `servicedesiredstate` - To indicate whether the service (and it components)
should or should not be secured
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentDesiredStateEntity.java
610f77f
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java
81de777
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceDesiredStateEntity.java
a74b021
ambari-server/src/main/java/org/apache/ambari/server/state/SecurityState.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/state/Service.java
4a18c69
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java
3142974
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java
4b4a305
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
606751d
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java
b5556ed
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql edcaa50
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8ab0619
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql a918f22
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql
2e7aa07
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql e3e3414
ambari-server/src/test/java/org/apache/ambari/server/state/ServiceTest.java
493291d
ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java
aa7aab5
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java
be9c9bf
Diff: https://reviews.apache.org/r/28095/diff/
Testing
-------
Java Unit Tests:
Tests run: 2250, Failures: 0, Errors: 0, Skipped: 14
Manual tests to verifty tables are altered and values are updated.
Thanks,
Robert Levas
