> On Nov. 24, 2014, 3:08 p.m., Sumit Mohanty wrote: > >
Can you also check nd provide correct fixVersion for the AMBARI JIRAs? I have deleted the fixVersion as it was saying 1.6.1. > On Nov. 24, 2014, 3:08 p.m., Sumit Mohanty wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java, > > line 662 > > <https://reviews.apache.org/r/20609/diff/5/?file=774113#file774113line662> > > > > Does UI in different conditions sends different strings? Could UI have > > modified the code to send only "true"? > > Dmytro Shkvyra wrote: > No, UI can as usual send "true", true and 'true' My question ws different. Does UI send all three variants "true", true and 'true' depending when and how the command is issued? In that case will it also send True TRUE? > On Nov. 24, 2014, 3:08 p.m., Sumit Mohanty wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java, > > line 2625 > > <https://reviews.apache.org/r/20609/diff/5/?file=774114#file774114line2625> > > > > In this scenario we are deleting the host component. Do we need this > > state check? What if the host component is in INSTALL_FAILED or INIT or > > some other state where it can be deleted. Should we not let the exclude > > file be cleaned in that case? > > Dmytro Shkvyra wrote: > This patch just recommit (clear excludes) and mark their master (need > restart) only for components which were decommited before deletion, so these > components should be in INSTALLED state, othewise we do not need clear > excludes and restrt masters. You are right that component should be in INSTALLED state. But I was wondering if that check is needed at all. We allow delete of a host component in any state other than STARTED. Anyway, lets leave the check as is. > On Nov. 24, 2014, 3:08 p.m., Sumit Mohanty wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java, > > line 2635 > > <https://reviews.apache.org/r/20609/diff/5/?file=774114#file774114line2635> > > > > Modify the context to "Remove host <host name here> from exclude file" > > Dmytro Shkvyra wrote: > I can do this, but we get some ambiguity in case if we have yarn.exclude > and dfs.exclude at same host. So in this case we should use "Remove host > <host name here> from <exclude> file" to inform user, about name of *.exclude > file which is undefined there (it is defined in pyhton code). Do you still > insist to rename context text? Yes, lets make the change and add the file name or component name as you suggested. > On Nov. 24, 2014, 3:08 p.m., Sumit Mohanty wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java, > > line 2653 > > <https://reviews.apache.org/r/20609/diff/5/?file=774114#file774114line2653> > > > > Why is restart required for master component? > > Dmytro Shkvyra wrote: > In order to remove hostname of removed slave from component UI (please > see original jira). Yusaku have pointed to this moment. Unfortunately, > hostname have been stored in memory of master, even if we use -refresh > command. So we need restart master to remove hostname info from components UI. Thanks for the details. - Sumit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20609/#review62769 ----------------------------------------------------------- On Nov. 24, 2014, 5:32 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20609/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2014, 5:32 p.m.) > > > Review request for Ambari, Dmytro Sen and Sumit Mohanty. > > > Bugs: AMBARI-5544 and AMBARI-5589 > https://issues.apache.org/jira/browse/AMBARI-5544 > https://issues.apache.org/jira/browse/AMBARI-5589 > > > Repository: ambari > > > Description > ------- > > We should set the state to INIT when the last host component gets removed > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > 4382c9f > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 8f90cf4 > > ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/package/scripts/hdfs_namenode.py > 5500b97 > > ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/package/scripts/params.py > fc53b44 > > ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/YARN/package/scripts/params.py > b942d03 > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/package/scripts/params.py > 15c0ef0 > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/package/scripts/params.py > 1900598 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_namenode.py > ed4d7bf > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py > 49ac408 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py > 5e066d9 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > 7a194a4 > ambari-server/src/test/python/TestAmbariServer.py caa87cc > ambari-server/src/test/python/stacks/1.3.2/HDFS/test_namenode.py 49ad368 > > ambari-server/src/test/python/stacks/1.3.2/configs/default_update_exclude_file_only.json > PRE-CREATION > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 2e12e19 > > ambari-server/src/test/python/stacks/2.0.6/configs/default_update_exclude_file_only.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/20609/diff/ > > > Testing > ------- > > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main ....................................... SUCCESS [3.651s] > [INFO] Apache Ambari Project POM ......................... SUCCESS [0.350s] > [INFO] Ambari Web ........................................ SUCCESS [8.150s] > [INFO] Ambari Views ...................................... SUCCESS [7.956s] > [INFO] Ambari Server ..................................... SUCCESS > [12:29.721s] > [INFO] Ambari Agent ...................................... SUCCESS [29.804s] > [INFO] Ambari Client ..................................... SUCCESS [0.562s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 13:23.772s > [INFO] Finished at: Wed Apr 23 17:13:04 FET 2014 > [INFO] Final Memory: 27M/262M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Dmitro Lisnichenko > >
