[
https://issues.apache.org/jira/browse/AMBARI-8429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14224471#comment-14224471
]
Hudson commented on AMBARI-8429:
--------------------------------
SUCCESS: Integrated in Ambari-trunk-Commit #1030 (See
[https://builds.apache.org/job/Ambari-trunk-Commit/1030/])
AMBARI-8429 Refactor version comparisons to use function (dsen) (dsen:
http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=accbbf2735d8a3ec1747cbdd7110bbac32db95db)
*
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/params.py
*
ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/package/scripts/params.py
*
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/params.py
*
ambari-server/src/main/resources/stacks/HDP/2.2/services/SLIDER/package/scripts/params.py
*
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/utils.py
*
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/oozie.py
*
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py
*
ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-ANY/scripts/params.py
*
ambari-server/src/main/resources/stacks/HDP/2.1/services/TEZ/package/scripts/params.py
*
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/package/scripts/params.py
*
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py
*
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/templates/startHiveserver2.sh.j2
*
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/service_check.py
*
ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/package/scripts/params.py
*
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/package/scripts/params.py
*
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/PIG/package/scripts/params.py
*
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/SQOOP/package/scripts/params.py
*
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
*
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/package/scripts/params.py
*
ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/package/scripts/storm.py
*
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/params.py
*
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/params.py
*
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-ANY/scripts/params.py
*
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/hive_server.py
*
ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/package/scripts/params.py
*
ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/package/scripts/params.py
*
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py
*
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/package/scripts/params.py
> Refactor version comparisons to use function
> --------------------------------------------
>
> Key: AMBARI-8429
> URL: https://issues.apache.org/jira/browse/AMBARI-8429
> Project: Ambari
> Issue Type: Bug
> Components: stacks
> Affects Versions: 1.7.0
> Reporter: Dmytro Sen
> Assignee: Dmytro Sen
> Fix For: 2.0.0
>
>
> In Ambari 1.7.0, we started introducing checks for the HDP version like
>
> stack_is_hdp22_or_further = not (stack_version.startswith('2.0') or
> stack_version.startswith('2.1'))
> This may lead to problems in future HDP versions.
> Instead, we should create a function/class for doing version comparisons.
> ambari-server.py already has a method called compare_versions() that compares
> the each segment of a version (separated by dots).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
