----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28455/#review63081 -----------------------------------------------------------
Ship it! Ship It! - Yusaku Sako On Nov. 26, 2014, 12:22 a.m., Xi Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28455/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2014, 12:22 a.m.) > > > Review request for Ambari, Jaimin Jetly and Yusaku Sako. > > > Bugs: AMBARI-8448 > https://issues.apache.org/jira/browse/AMBARI-8448 > > > Repository: ambari > > > Description > ------- > > # Alert-groups combo contents should be sorted alphabetically. (also, All > Default groups at top, followed by customized groups) > # Alert-groups combo should look like the Filter combo on Hosts page > {{Groups: All(54)}}, or {{Groups: YARN Default (18)}}. > # Move Actions combo to the left of Alert-groups combo > # Summary table default sort order should be the severity of status in > descending value - Criticals count > Warnings count > OK count > # Enabled disabled column should have a filter with options > {{All|Enabled|Disabled}}. Each should show in text {{Enabled}} or > {{Disabled}}. The icon should be to the right of the text and will be the > action to enable/disable. > # Enable/Disable action should ask for confirmation > # Footer text {{58 of 58 alerts showing - clear filters}} should be changed > to {{58 of 58 definitions showing - clear filters}} > # Column title {{Name}} should be changed to {{Definition Name}} > > > Diffs > ----- > > ambari-web/app/controllers/main/alert_definitions_controller.js 88c9ff7 > ambari-web/app/messages.js 5a7ff55 > ambari-web/app/models/alert_definition.js 9d5f52c > ambari-web/app/styles/alerts.less af69fe8 > ambari-web/app/styles/application.less ab0558b > ambari-web/app/templates/main/alerts.hbs fb53f17 > ambari-web/app/views/common/filter_view.js 1efcb72 > ambari-web/app/views/common/sort_view.js e66630c > ambari-web/app/views/main/alert_definitions_view.js c8535cc > ambari-web/test/controllers/main/alert_definitions_controller_test.js > a605899 > > Diff: https://reviews.apache.org/r/28455/diff/ > > > Testing > ------- > > unit tests passed > > > Thanks, > > Xi Wang > >
