----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28473/#review63115 -----------------------------------------------------------
Ship it! Ship It! - Oleg Nechiporenko On Nov. 26, 2014, 4:27 p.m., Alexandr Antonenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28473/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2014, 4:27 p.m.) > > > Review request for Ambari and Oleg Nechiporenko. > > > Bugs: AMBARI-8403 > https://issues.apache.org/jira/browse/AMBARI-8403 > > > Repository: ambari > > > Description > ------- > > Attempted to download a folder as a ZIP by clicking on the filebox icon on > the folder row in the table. > This fails. But for this folder, I don't have read access, so it should > fail... > Is see the POST worked to get the > {"requestId":"56b0e03a123f4b2da97b5caa3beefe13"} > /api/v1/views/FILES/versions/0.1.0/instances/FILES_1/resources/files/download/zip/generate-link > It gets a 500 on this GET call: > /api/v1/views/FILES/versions/0.1.0/instances/FILES_1/resources/files/download/zip?requestId=56b0e03a123f4b2da97b5caa3beefe13 > > > Diffs > ----- > > contrib/views/files/pom.xml dd8325e > > contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/DownloadService.java > 72ba726 > > contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/FileOperationService.java > d043917 > > contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsApi.java > cd88c54 > > contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HdfsService.java > 06f27b0 > > contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/HelpService.java > d12c47c > > contrib/views/files/src/main/java/org/apache/ambari/view/filebrowser/UploadService.java > 1ff5571 > contrib/views/files/src/main/resources/ui/app/adapter.js a6e471f > contrib/views/files/src/main/resources/ui/app/controllers/file.js f8b7046 > contrib/views/files/src/main/resources/ui/app/controllers/files.js a9d98e8 > contrib/views/files/src/main/resources/ui/app/models/file.js 6908f44 > > contrib/views/files/src/main/resources/ui/app/templates/components/contextMenu.hbs > 844363c > contrib/views/files/src/main/resources/ui/app/templates/files.hbs 6f65e91 > contrib/views/files/src/main/resources/ui/app/templates/util/fileRow.hbs > 052a14e > contrib/views/files/src/main/resources/ui/bower.json 9579a32 > contrib/views/files/src/main/resources/ui/config.coffee 36889ce > contrib/views/files/src/main/resources/ui/package.json 54d6788 > contrib/views/files/src/main/resources/view.xml 69586d1 > > contrib/views/files/src/test/java/org/apache/ambari/view/filebrowser/FilebrowserTest.java > 6eb10e3 > > Diff: https://reviews.apache.org/r/28473/diff/ > > > Testing > ------- > > > Thanks, > > Alexandr Antonenko > >
