> On Nov. 26, 2014, 1:31 a.m., Nate Cole wrote: > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_namenode.py, > > lines 73-78 > > <https://reviews.apache.org/r/28369/diff/4/?file=776340#file776340line73> > > > > Conditional on RU?
This worked during a normal HDFS Namenode restart. I haven't tested it during HA mode. > On Nov. 26, 2014, 1:31 a.m., Nate Cole wrote: > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/zookeeper_service.py, > > lines 44-53 > > <https://reviews.apache.org/r/28369/diff/4/?file=776345#file776345line44> > > > > On every start? Maybe this should be conditional on some other > > parameter passed with the RESTART command that we add specific for rolling > > upgrade. That's a good idea, I'll track these improvements in a Jira so we can tackle them later. - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28369/#review63086 ----------------------------------------------------------- On Nov. 26, 2014, 12:40 a.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28369/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2014, 12:40 a.m.) > > > Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Yurii Shylov. > > > Bugs: AMBARI-8450 > https://issues.apache.org/jira/browse/AMBARI-8450 > > > Repository: ambari > > > Description > ------- > > HDFS and ZK need an upgrade pack that works according to the run book. > > > Diffs > ----- > > ambari-common/src/main/python/resource_management/core/shell.py 2a472f2 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > d0a9e19 > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java > d4cbd4e > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ExecuteTask.java > 26b7b1e > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java > d245b51 > ambari-server/src/main/resources/custom_actions/scripts/ru_execute_tasks.py > cd3e36e > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_namenode.py > eefc668 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/utils.py > 327d44e > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/files/zkSmoke.sh > f6ff2ba > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/params.py > fb55f48 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/service_check.py > 87c13db > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/zookeeper_service.py > 639fe98 > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml > feb26fd > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py e5bea87 > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py ee7825b > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 384c21b > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_snamenode.py 33d8ef6 > ambari-server/src/test/python/stacks/2.0.6/HDFS/test_zkfc.py 03a042b > > ambari-server/src/test/python/stacks/2.0.6/ZOOKEEPER/test_zookeeper_server.py > fad5d04 > > Diff: https://reviews.apache.org/r/28369/diff/ > > > Testing > ------- > > Ran unit tests, > > ---------------------------------------------------------------------- > Total run:674 > Total errors:0 > Total failures:0 > OK > > Verified this worked on a live cluster with HDFS and ZK intalled. > > *Useful Tips* > > Do once, > curl -X POST -u admin:admin -H 'X-Requested-By:1' > http://c6407.ambari.apache.org:8080/api/v1/repository_versions -d > '{"RepositoryVersion": {"display_name": "HDP-2.2.0.1-885", "version": > "2.2.0.1-885", "stack": "HDP-2.2", "upgrade_pack": "upgrade-2.2", > "repositories": [{"os": "redhat6", "baseurls": [{"id": "HDP-2.2.0.1-885", > "type": "HDP", "baseurl": "http://host1/hdp"}, {"id": "HDP-UTILS-1.0.0.20", > "type": "HDP-UTILS", "baseurl": "http://host1/hdp-utils"}]}]}}' > > Run for each attempt, > curl -X POST -u admin:admin -H 'X-Requested-By:1' > http://c6407.ambari.apache.org:8080/api/v1/clusters/dev/upgrades -d > '{"Upgrade": {"version": "2.2.0.1-885"}}' > > Look at results, > http://c6407.ambari.apache.org:8080/api/v1/clusters/dev/upgrades/1?fields=upgrade_items/UpgradeItem/text > http://c6407.ambari.apache.org:8080/api/v1/clusters/dev/requests/1?fields=tasks/Tasks/command_detail,tasks/Tasks/status,tasks/Tasks/stdout > > > Make changes to scripts in question. E.g., > yes | cp > /vagrant/ambari/ambari-server/target/ambari-server-1.3.0-SNAPSHOT.jar > /usr/lib/ambari-server/ > yes | cp > /vagrant/ambari/ambari-server/src/main/resources/custom_actions/scripts/ru_execute_tasks.py > /var/lib/ambari-agent/cache/custom_actions/scripts/ru_execute_tasks.py > yes | cp > /vagrant/ambari/ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml > /var/lib/ambari-server/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml > ambari-server restart > > Run just ru_execute_tasks.py, > /usr/bin/python2.6 > /var/lib/ambari-agent/cache/custom_actions/scripts/ru_execute_tasks.py > ACTIONEXECUTE /var/lib/ambari-agent/data/command-315.json > /var/lib/ambari-agent/cache/custom_actions > /var/lib/ambari-agent/data/structured-out-315.json INFO > /var/lib/ambari-agent/data/tmp > > > Thanks, > > Alejandro Fernandez > >
