----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28454/#review63128 -----------------------------------------------------------
Ship it! The patch looks fine to me. I've just added a minor issue regarding the naming of parameters. ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/utils.py <https://reviews.apache.org/r/28454/#comment105324> Maybe consider changing the "null_value" parameter name to something like "default_value". I found the original naming to be a little confusing. - Robert Nettleton On Nov. 25, 2014, 10:18 p.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28454/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2014, 10:18 p.m.) > > > Review request for Ambari, Jaimin Jetly, Nate Cole, Robert Nettleton, and > Yusaku Sako. > > > Bugs: AMBARI-8436 > https://issues.apache.org/jira/browse/AMBARI-8436 > > > Repository: ambari > > > Description > ------- > > On Install aand Test kerberos page, If optional values for test principal and > test keytab are left blank then test kerberos command (kerberos service > check) fails. > > This occurs because test user details are empty rather than missing from the > request/configuration. > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/params.py > cff6250 > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/service_check.py > 73b9c7a > > ambari-server/src/main/resources/stacks/HDP/2.2/services/KERBEROS/package/scripts/utils.py > 79e89e6 > ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py > 95c357d > > Diff: https://reviews.apache.org/r/28454/diff/ > > > Testing > ------- > > Added new unit test in > .../ambari/ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py > > Running tests for stack:2.2 service:KERBEROS > test_configure_cross_realm_trust (test_kerberos_client.TestKerberosClient) > ... ok > test_configure_managed_kdc (test_kerberos_client.TestKerberosClient) ... ok > test_configure_unmanaged_ad (test_kerberos_client.TestKerberosClient) ... ok > test_configure_unmanaged_kdc (test_kerberos_client.TestKerberosClient) ... ok > **test_get_property (test_kerberos_client.TestKerberosClient) ... ok** > test_configure_cross_realm_trust (test_kerberos_server.TestKerberosServer) > ... ok > test_configure_managed_kdc (test_kerberos_server.TestKerberosServer) ... ok > test_configure_unmanaged_ad (test_kerberos_server.TestKerberosServer) ... ok > test_configure_unmanaged_kdc (test_kerberos_server.TestKerberosServer) ... ok > > ---------------------------------------------------------------------- > Ran 9 tests in 0.153s > > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 35:30 min > [INFO] Finished at: 2014-11-25T21:16:22+00:00 > [INFO] Final Memory: 43M/355M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Robert Levas > >
