----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28554/#review63357 -----------------------------------------------------------
Ship it! Ship It! - Aleksandr Kovalenko On Гру. 1, 2014, 2:17 після полудня, Oleg Nechiporenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28554/ > ----------------------------------------------------------- > > (Updated Гру. 1, 2014, 2:17 після полудня) > > > Review request for Ambari and Aleksandr Kovalenko. > > > Bugs: ambari-8494 > https://issues.apache.org/jira/browse/ambari-8494 > > > Repository: ambari > > > Description > ------- > > Currently all last-triggered times are shown as absolute times. We should > change that to show time relative to now, like {{30 seconds ago}}. > > The resolution of the relative time depends on how large the gap is. If less > than minute, we show seconds. If less than 1 hour, we show minutes+seconds. > If less than a day, we show hours+minutes. If less than 1 week, we show days > + hours. If less than 1 month, we show weeks + days. etc... > > Hovering on this text however, should show the absolute time. > > This should be used wherever we show last-triggered times (cluster > alert-definitions table, definition-detail instances table, > definition-details page, host alerts table). > > > Diffs > ----- > > ambari-web/app/models/alert_definition.js bf5d434 > ambari-web/app/models/alert_instance.js 6590941 > ambari-web/app/templates/main/alerts.hbs ded942f > ambari-web/app/templates/main/alerts/definition_details.hbs fd17831 > ambari-web/app/templates/main/host/host_alerts.hbs d7576ff > ambari-web/app/views/main/alert_definitions_view.js 1300c83 > ambari-web/app/views/main/alerts/definition_details_view.js 8490755 > ambari-web/test/models/alert_definition_test.js 951ac26 > > Diff: https://reviews.apache.org/r/28554/diff/ > > > Testing > ------- > > 4984 tests complete (7 seconds) > 60 tests pending > > > Thanks, > > Oleg Nechiporenko > >
