> On Dec. 1, 2014, 12:44 p.m., Dmitro Lisnichenko wrote:
> > As I understand the idea of this jira, classes (and tests for them) should
> > be moved to separate files since ambari-server.py is getting too large?
No, the main idea is separate functionality of ambari-server.py to classes but
we do not need separate it to different files. I have to separate
functionality, because in case of main task ("should not show traceback on
exception during setup") we cant fix unitests. Earlier, I have extracted
firewall class as file, but it was need because we had duplacates of this code
in server and agent. In this case we will not reuse code, but we have
"spagetti code" which we cant test in normal way.
- Dmytro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28529/#review63352
-----------------------------------------------------------
On Nov. 28, 2014, 6:46 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28529/
> -----------------------------------------------------------
>
> (Updated Nov. 28, 2014, 6:46 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, John Speidel, Mahadev Konar,
> Nate Cole, and Jeff Sposetti.
>
>
> Bugs: AMBARI-8475
> https://issues.apache.org/jira/browse/AMBARI-8475
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Extract HTTPS_Manager and JDK_manager classes from ambari-server.py
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari-server.py fc3b843
> ambari-server/src/test/python/TestAmbariServer.py 0eae33b
>
> Diff: https://reviews.apache.org/r/28529/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
