----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28658/#review63712 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java <https://reviews.apache.org/r/28658/#comment105987> According to the tech doc, **name** field should contain stackId (like HDP-2.2) and **version** field should store repository version, not stack version ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java <https://reviews.apache.org/r/28658/#comment105995> How about removing call repositoryVersionDAO.create(entity) at org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java:158 if we are adding create method with advanced validation? - Dmitro Lisnichenko On Dec. 3, 2014, 7:15 p.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28658/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2014, 7:15 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko and Nate Cole. > > > Bugs: AMBARI-8532 > https://issues.apache.org/jira/browse/AMBARI-8532 > > > Repository: ambari > > > Description > ------- > > Creating a cluster needs to populate the repo_version table with the same > stack name and stack version that is used in the cluster_version table. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterStackVersionService.java > f9ae235 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/HostStackVersionService.java > d0f872d > > ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java > c34ee3d > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 7c533d0 > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java > 7ac0df9 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java > df0a04f > ambari-web/app/mappers/stack_mapper.js 4bfea03 > > Diff: https://reviews.apache.org/r/28658/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 26:28.562s > [INFO] Finished at: Wed Dec 03 10:51:32 PST 2014 > [INFO] Final Memory: 51M/338M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Alejandro Fernandez > >
