----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28629/#review63702 -----------------------------------------------------------
Ship it! LGTM ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java <https://reviews.apache.org/r/28629/#comment105983> We can address robustness later. ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml <https://reviews.apache.org/r/28629/#comment105981> We'll eventually change this to 33. ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml <https://reviews.apache.org/r/28629/#comment105979> We'll bump this up to 33, can be done in a future patch. - Alejandro Fernandez On Dec. 3, 2014, 3:27 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28629/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2014, 3:27 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Dmitro Lisnichenko. > > > Bugs: AMBARI-8465 > https://issues.apache.org/jira/browse/AMBARI-8465 > > > Repository: ambari > > > Description > ------- > > Once the backend can support groupings, alter the engine to generate tasks in > grouping order. > > Also moved a lot of junk out of UpgradeResourceProvider and into a helper > class. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java > d0664df > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java > d2660e0 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 6980e15 > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java > 3057db3 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Batch.java > 4ff0c66 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ColocatedGrouping.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConditionalBatch.java > e88d67c > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/CountBatch.java > c55f569 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/PercentBatch.java > d67bb0b > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RestartTask.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapper.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilder.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Task.java > 4cda5da > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/TaskWrapper.java > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml > 9fc5752 > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java > 98175ee > > ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java > 947b994 > ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_test.xml > 90e907b > > Diff: https://reviews.apache.org/r/28629/diff/ > > > Testing > ------- > > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 14:55.382s > [INFO] Finished at: Tue Dec 02 21:04:42 PST 2014 > [INFO] Final Memory: 27M/317M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Nate Cole > >
