----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28644/#review63725 -----------------------------------------------------------
The two files should be moved to: ``` contrib/nagios-alerts/plugins/ambari_alerts.py contrib/nagios-alerts/plugins/generate_nagios_objects.py ``` This will involve updating the RPM and Debian builder scripts. contrib/addons/src/addOns/nagios/plugins/generate_nagios_objects.py <https://reviews.apache.org/r/28644/#comment106012> I think that this is an issue here as we're creating a Nagios template for the alert command with the username and password in plaintext as arguments. We need to obfuscate this on some level so someone looking at the file can't just figure out what it is. - Jonathan Hurley On Dec. 3, 2014, 7:34 a.m., Yurii Shylov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28644/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2014, 7:34 a.m.) > > > Review request for Ambari, Jonathan Hurley and Nate Cole. > > > Bugs: AMBARI-8165 > https://issues.apache.org/jira/browse/AMBARI-8165 > > > Repository: ambari > > > Description > ------- > > The Ambari Server will be responsible for scheduling the dispatching of > alerts that have been received and not yet processed for outbound > notification. On a schedule, Ambari will determine the alert targets that > should be receiving some sort of notification and then it will gather all > alert data for all alerts that are destined for that alert target. > Nagios is a required notification mechanism. The Nagios server will surface > the current state of each alert defined in the system. In order to accomplish > this there are two possible methods for implementation: > 1) Write a python script that Nagios will execute on its own schedule which > can then retrieve the current alerts from Ambari's REST APIs. The script will > take a combination of parameters (host, security, certificate, etc) in order > to make the requests. > 2) Write a dispatcher that can handle pushing data to a Nagios server. There > will no longer be an agent running on Nagios, so this method would need to > work with Nagios' built-in mechanism, if any, for publishing data into Nagios. > > > Diffs > ----- > > contrib/addons/src/addOns/nagios/plugins/ambari_alerts.py PRE-CREATION > contrib/addons/src/addOns/nagios/plugins/generate_nagios_objects.py > PRE-CREATION > > Diff: https://reviews.apache.org/r/28644/diff/ > > > Testing > ------- > > Total run:674 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Yurii Shylov > >
