----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28808/#review64274 -----------------------------------------------------------
Nice! ambari-common/src/main/python/resource_management/libraries/functions/decorator.py <https://reviews.apache.org/r/28808/#comment106913> Strange to have this here? ambari-common/src/main/python/resource_management/libraries/functions/decorator.py <https://reviews.apache.org/r/28808/#comment106912> Can just: return function(*args, **kwargs) No need for 'out' assignment. ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java <https://reviews.apache.org/r/28808/#comment106911> A regular HashMap is fine - Nate Cole On Dec. 8, 2014, 3:36 p.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28808/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2014, 3:36 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Tom Beerbower. > > > Bugs: AMBARI-8593 > https://issues.apache.org/jira/browse/AMBARI-8593 > > > Repository: ambari > > > Description > ------- > > Services will need a pre-restart and post-restart hook that can perform the > following actions. > Pre-restart, needs to call hdp-select with the version number. It should only > be called during a RESTART command that is performed during a Rolling Upgrade. > Post-restart, needs to perform several checks, like ZK quorum is established > and namenode is live. > > > Diffs > ----- > > ambari-common/src/main/python/resource_management/core/shell.py d832781 > > ambari-common/src/main/python/resource_management/libraries/functions/decorator.py > PRE-CREATION > > ambari-common/src/main/python/resource_management/libraries/functions/version.py > 9477842 > > ambari-common/src/main/python/resource_management/libraries/script/script.py > 39511bc > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > 7e07453 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode.py > c1a66fb > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/namenode.py > 5cc00fc > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/utils.py > b786204 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/zookeeper_server.py > 9b9112c > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/package/scripts/zookeeper_service.py > 724e101 > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml > 752f504 > > Diff: https://reviews.apache.org/r/28808/diff/ > > > Testing > ------- > > Deployed a new cluster and updated the jar and python scripts. Then perform > an upgrade using the upgrade-2.2.xml pack > ----------------------------------------------------------------------- > Ran 246 tests in 3.359s > > OK > ---------------------------------------------------------------------- > Total run:674 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Alejandro Fernandez > >
