-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28902/#review64579
-----------------------------------------------------------
Tez in HDP-2.2 does not inherit any configs from HDP-2.1 (AMBARI-7921).
And Tez HDP-2.2 does not have {{tez.am.java.opts}} config (AMBARI-7935).
So 2 fixes are needed
# HDP-2.2 _stack_advisor.py_ should not recommend or validate
{{tez.am.java.opts}} or any config no longer provided in HDP-2.2
# Ambari UI should display errors/warnings even when there are no config keys.
These errors/warnings should show up at the top of the config-page saying
{{Value should be set - 'tez.am.java.opts' in 'tez-site'}}.
So the patch should include changes in stack_advisor.py in HDP-2.2, and UI
javascript changes to make sure errors with no corresponding config show up on
top of page - giving chance for user to add.
- Srimanth Gunturi
On Dec. 10, 2014, 3:17 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28902/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2014, 3:17 p.m.)
>
>
> Review request for Ambari and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-8635
> https://issues.apache.org/jira/browse/AMBARI-8635
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Went and changed a tez property, POST /validations is called and the response
> returns two things: WARN and ERROR.
>
> Only the WARN is showing in the UI. Need to also inform the user about ERROR.
>
> See attached.
>
>
> Diffs
> -----
>
>
> ambari-server/src/main/resources/stacks/HDP/2.2/services/TEZ/configuration/tez-site.xml
> 50345fd
>
> Diff: https://reviews.apache.org/r/28902/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
