----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28944/#review65015 -----------------------------------------------------------
Ship it! Let me know if you want to upload another patch for these comments or if you are ok with me merging this patch. ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java <https://reviews.apache.org/r/28944/#comment107934> Why not use a static import import static org.apache.ambari.server.serveraction.kerberos.KerberosActionDataFile.KEYTAB_FILE_PATH ? ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java <https://reviews.apache.org/r/28944/#comment107935> same comment a precdeing line ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java <https://reviews.apache.org/r/28944/#comment107936> static import? - John Speidel On Dec. 13, 2014, 2:16 a.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28944/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2014, 2:16 a.m.) > > > Review request for Ambari, dilli dorai, John Speidel, and Robert Nettleton. > > > Bugs: AMBARI-8657 > https://issues.apache.org/jira/browse/AMBARI-8657 > > > Repository: ambari > > > Description > ------- > > Provide a facility to write (build) and read a (temporary) file used to hold > data needed for updating the configuration data of services to be configured > for Kerberos. > > The format of the file should be hidden from the user of this facility, but > will be CSV. > > Added new classes: > * > org.apache.ambari.server.serveraction.kerberos.AbstractKerberosDataFileBuilder > (mostly code moved from > org.apache.ambari.server.serveraction.kerberos.KerberosActionDataFileBuilder) > * > org.apache.ambari.server.serveraction.kerberos.AbstractKerberosDataFileReader > (mostly code moved from > org.apache.ambari.server.serveraction.kerberos.KerberosActionDataFileReader) > * org.apache.ambari.server.serveraction.kerberos.KerberosConfigDataFile > * org.apache.ambari.server.serveraction.kerberos.KerberosConfigDataFileBuilder > * org.apache.ambari.server.serveraction.kerberos.KerberosConfigDataFileReader > * org.apache.ambari.server.serveraction.kerberos.KerberosConfigDataFileTest > > Updated existing classes to implement abstract builder and reader : > * org.apache.ambari.server.serveraction.kerberos.KerberosActionDataFileBuilder > * org.apache.ambari.server.serveraction.kerberos.KerberosActionDataFileReader > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractKerberosDataFileBuilder.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractKerberosDataFileReader.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java > 057bf18 > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFile.java > f2a0f06 > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileBuilder.java > b19e6f4 > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileReader.java > f3d93f5 > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosConfigDataFile.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosConfigDataFileBuilder.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosConfigDataFileReader.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java > 788e087 > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosActionDataFileTest.java > 71b3084 > > ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosConfigDataFileTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/28944/diff/ > > > Testing > ------- > > Additional unit test: > org.apache.ambari.server.serveraction.kerberos.KerberosConfigDataFileTest > Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.087 sec > > Existing unit test: > org.apache.ambari.server.serveraction.kerberos.KerberosActionDataFileTest > Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.102 sec > > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 26:46.040s > [INFO] Finished at: Thu Dec 11 10:39:48 EST 2014 > [INFO] Final Memory: 45M/774M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Robert Levas > >
