> On Dec. 13, 2014, 4:38 p.m., Nate Cole wrote: > > ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py, lines > > 123-124 > > <https://reviews.apache.org/r/29017/diff/1/?file=791191#file791191line123> > > > > I personally favor the (.., ..) syntax for tuple returns like you have > > here, because it makes it obvious it's a tuple. Alejandro says it's not > > required. Whichever you pick, I'll start doing too.
I also prefer (...,...) syntax - the weak typing and contracts make reading other people's code hard enough. You're right that this isn't required, but I think it's way easier to understand. - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29017/#review65030 ----------------------------------------------------------- On Dec. 13, 2014, 12:03 a.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29017/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2014, 12:03 a.m.) > > > Review request for Ambari and Nate Cole. > > > Bugs: AMBARI-8699 > https://issues.apache.org/jira/browse/AMBARI-8699 > > > Repository: ambari > > > Description > ------- > > 1) Add a warning level to type=PORT alerts > 2) expose ability to set the response threshold for warn and crit > 3) default to 1 sec and 5 secs > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py 4daa74c > ambari-agent/src/test/python/ambari_agent/TestAlerts.py 96be539 > > ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/GANGLIA/alerts.json > 6a44810 > > ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HBASE/alerts.json > dc2675b > > ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HDFS/alerts.json > 1ca4180 > > ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/HIVE/alerts.json > 60c1d48 > > ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/YARN/alerts.json > 7e91a86 > > ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/ZOOKEEPER/alerts.json > fdb6fd8 > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/GANGLIA/alerts.json > 60acc7c > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/alerts.json > a875d24 > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/alerts.json > 3cb5d37 > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/alerts.json > fa9b06d > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/alerts.json > fb360a5 > > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/ZOOKEEPER/alerts.json > 1fa2a0d > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/alerts.json > 6a44810 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/alerts.json > 7920b03 > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/alerts.json > 4c90697 > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/alerts.json > a14ab13 > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/alerts.json > 3f97a2f > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/alerts.json > 1fa2a0d > ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/alerts.json > 72f59f6 > ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/alerts.json > ff9d91c > > ambari-server/src/main/resources/stacks/HDP/2.2.GlusterFS/services/KAFKA/alerts.json > ad4af4f > > ambari-server/src/main/resources/stacks/HDP/2.2.GlusterFS/services/KNOX/alerts.json > 236875a > ambari-server/src/main/resources/stacks/HDP/2.2/services/AMS/alerts.json > 0a1e469 > ambari-server/src/main/resources/stacks/HDP/2.2/services/KAFKA/alerts.json > dfb1a65 > ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/alerts.json > f9ec8da > > Diff: https://reviews.apache.org/r/29017/diff/ > > > Testing > ------- > > Verified thresholds work by turning down the values to .01 and watching the > different alert states trigger. > > New python tests added: > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 9.936 s > [INFO] Finished at: 2014-12-12T23:49:34-05:00 > [INFO] Final Memory: 8M/81M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Jonathan Hurley > >
